lamden / wallet Goto Github PK

Official Lamden wallet as a Google Chrome plugin. Also includes native atomic swap tools.

JavaScript 36.00% HTML 0.06% CSS 1.80% Svelte 61.74% Python 0.39%

wallet's Introduction

Lamden Blockchain

Lamden is an open-source Python-based blockchain development platform designed to help developers create new blockchain applications and networks quickly and easily. With Lamden, developers can leverage the power of blockchain technology to create secure and decentralized applications.

Features

Quick and easy setup: Lamden provides a suite of tools and infrastructure to help developers get started with blockchain development quickly and easily.
Flexible and customizable: Lamden is designed to be flexible and customizable, so developers can tailor it to meet their specific needs and requirements.
Secure and decentralized: Lamden is built on the principles of security and decentralization, so applications developed with Lamden are secure and decentralized by default.

Getting Started

Getting started with Lamden is easy. Our team has produced a great documentation which you can check out here.

Community

Join the Lamden community to connect with other developers and get help and support. You can find us on:

Contributions

Lamden is an open-source project, and contributions are welcome. If you're interested in contributing, check out our contribution guidelines to get started.

wallet's People

Contributors

Stargazers

Watchers

wallet's Issues

Strange layout of components

The layout of the "Create a password" Screen seems strange and not finished:

There is a lot of space at the top, but on the bottom are too much elements fighting for space
The layout of the components should be centered and stacked. Now the form is next to the 4-step component

=> Would be much cleaner if the 4-Step component would be centered at the top (and the form also centered below it)

(I use a Mac Book Pro with 2880 x 1800)

Wallet doesn't respond after input password when refreshing the page

The wallet does not respond when giving my password. It worked before but after several refreshes, it stopped responding.

Companion App for Privat keys

Adding an companion app like MEWconnect for the Lamdenwallet would be a great and easy help to secure privat keys and funds.

minor UI edit with < BACK

Download wallet fresh, either create or restore wallet. Then click "< BACK"
"<" turns blue when hovered over, but does not do anything when clicked.
"BACK" does not turn blue when hovered over, and cursor becomes text cursor

Mouse Hover Arrow

Areas of the page that are selectable like the menu or buttons, my mouse arrow appears as if it’s text or not a clickable arrow.

Solution - Show the finger mouse cursor arrow when hovering on an element that's clickable to the user.

UX: Save My Progress

Describe the bug
As a user, I want to use the Clove Wallet and I want it to save my progress where I just was. When I close the Clove Wallet, and reopen it, it keeps taking me back to the Lamden Wallet.

To Reproduce
Navigate to Clove Wallet
Navigate away from the Clove Wallet by selecting something in the browser
Navigate back to the Chrome Extension

Screenshots

Checkbox to agree to Token Swap terms and conditions is greyed out

After going to the bottom of the scroll box, the checkbox still remains greyed out. The checkbox can only be clicked after you manually resize the dropdown box by dragging the bottom right corner.

Logo Visibility

In Chrome on dark mode, I can barely see the Lamden chrome extension logo because it's dark purple on dark gray.

UX: Toggles Not Working

Describe the bug
As a user, I want to be able to toggle on and off the coins I want to use. When I try to toggle the coins on and off, they aren't responding.

To Reproduce
Navigate to Clove wallet
Add Coin
Select Toggle on and off

Screenshots

Incorrect balances are displayed

The main balance, should be the sum of all accounts in the wallet.
After testnet reset, this is not the case anymore. See screenshot:

Also the balance on my main account is displayed as 0
But if i call the REST Api of the Testnet, the balance is not zero:

https://testnet-master-1.lamden.io/contracts/currency/balances?key=9f89d0fc40f8e970e8787420b85bf080e771781c3011a1bcf8d2bdf0d7f05e30

Password not accepted, even if all green checkmarks are displayed

Cannot create a new wallet with password 01234567890!A (even if all checks are marked as passed)

Tried 3 times with different passwords, none of them worked (and all of them passed the checks)

Help FAQ

Restore screens and backup screens have links to Help and FAQ. The idea was that if a user was stuck, we could give help information to them on lamden.io.

Solution: As a quick fix, can we redirect them to the feedback form and add a feedback type as "help"? Open to ideas about this if you have other thoughts.

Clicking 'TX Details' in wallet links to wrong url

Clicking 'TX Details' button sends user to e.g

https://testnet.lamden.io/transaction/2a54b5669565909e7fd9301f3a143b224466c9e9cdab86ad9e866ca17a58d3c3

while it should be :

https://testnet.lamden.io/transactions/2a54b5669565909e7fd9301f3a143b224466c9e9cdab86ad9e866ca17a58d3c3

Holdings Graphic Too Large

Due to the holdings graphic being large in height, the users holdings are pushed further down on the page and they’re only able to see 1 of their holdings. If the user doesn't have any holdings, they may not see Create a Wallet or Restore a Wallet.

Solution - Change the height of the image (~265px) to bring the users holdings up further up on the page.

cypress tests broken

Cypress tests no longer work. I'm assuming the monaco-editor package has some import that it cannot handle.

I'll have to find a new package. The cypress package was hefty so something more lightweight will be better.

This looks promissing:
https://testing-library.com/docs/svelte-testing-library/intro

Switching smart contract not working

Problem:
i have a Web Ui, with interacts with a smart contract named "con_v1"
Everything works fine until the point where i decide to replace my contract with a newer version "con_v2"

If i change my javascript code to interact with the new wallet the user is stuck.
Because the Wallet checks only for the URL it thinks that everything is fine
But if the user wants to interact with the UI, it's not working because he has no account linked to "con_v2"

The only way for the user is to manually delete the "old" account linked to "con_v1". After this he is prompted correctly to create an account von "con_v2"

Suggestion
The logic which checks the interaction between the UI and the account should not only check for the URL but also for the contract name.

UX: Confusing Title

Describe the bug
As a user, I want to be able to backup and restore my private keys. In the menu I see backup and restore, but when I navigate to it, restore is first and backup is second. Either name is backup and restore and put backup first or name it restore and backup and put restore first.

To Reproduce
Open menu and see backup and restore
See restore and backup

Screenshots

Show warning on contract submission

At the contract submission dialog there is a (optional) attribute called owner.
If this is set at submission time, only the owner can interact with exported methods of the smart contract.

Therefore a warning should be displayed when the owner field is filled at the submission dialog.

UX: Public Key

Describe the bug
As a user, after I save my private keys make it clear to me that the characters displaying are my public key and not my private key. I was worried for a second that you were showing my private key in plain site.

To Reproduce
Navigate to Clove wallet
Add Label
Add Eth Key
Submit
See the characters displaying that represent my public key and not my private key

Screenshots

Heavy delays make plugin unusable

Affected Version: 0.1.0
Browserversion: Chrome 73.0.3683.103
OS: Mac OS 10.14.4 (Mojave)

If I start the plugin the first time and the form for entering the desired wallet password is presented, things turn really slow.

Cannot focus any of the two textfields (no cursor is displayed)
if i type a character i need to wait up to 30sec until the character is displayed
Sometimes it's not working at all and no character is displayed
Pressing the "submit" button also does nothing. Not even an error message is displayed if nothing is entered.

I deactivated all other chrome extensions, but the issue still remains.

word-break: break-word;

For users with lower resolution screens, don't make them scroll horizontally to see transactions history. They'll miss the stamps used and timestamp columns.

Consider using this CSS on the table (word-break: break-word;) or something equivalent to wrap the long addresses.

Here's what it will look like after:

Change caption for account deletion

To delete an existing account you need to press a button with caption "Delete coin from wallet". The term "coin" should be replaced with "account" .

Create npm library for walletController

The walletController handles low-level interaction beween the UI and the Wallet.
At the moment the code has to be copied by everyone who wants to interact with the wallet.

Also the following code is very likely to break on future wallet releases:

if (err === "Wallet is Locked") this.locked = true
if (err.includes("You must be an authorized dApp")) this.authorized = false

Therefore it would be much cleaner to provide an npm package wich ist released together with new wallet versions and has backwards compatibility built in.

The new npm package should be able to inform for several wallet states/informations:

Installed: yes or no
Locked: yes or no
Account already created: yes or no
Account approved (amount) to interact with the contract: number of approved coins
Balance of the linked account

UX Improvement: Change Edit Wallet Name Location

Move changing the wallet name from:
Holdings -> Wallet -> Receive -> Edit
Holdings -> Wallet -> Edit

Move the button to the Purple Model next to 'Send' and 'Receive'

UI Consistency - Flip Buttons

Primary buttons should always be purple and secondary buttons should be gray.
Solution - you just need to flip the button styles (I understand button should be purple).

Give Feedback

Give feedback is asking for 2 email addresses instead of just 1.

Show/i

Metamask-alike functionality

Is there a way to access your extension from the webpage? So the website gives the tx to the extension for signing, and extension return signed tx in the callback?

Navigation Arrows

These arrows pointing down don’t do anything when they’re clicked and they look clickable.

Solution - You could remove the arrows entirely, I don't think they add anything.

Logo Selectable

The logo should always direct the user home (holdings page). This helps the user if they ever get lost or stuck they have a quick path home.

Social Media Icons

Social media icons don't link properly. Made with <3 by Lamden is really sweet, can this live on every page and link to lamden.io?

Ledger Integration

Integrating ledger support would be much more secure for the user. As a user, I prefer security over convenience. Having control of my private keys is a must. Metamask has implemented ledger support for reference.

Wallet nickname

Holdings -> My TAU Address -> options -> edit -> (new nickname) -> displays new nickname -> RELOAD PAGE -> Nickname reverts to "My TAU Address"

Commas in Amount

Commas so the user doesn't have to use mental math to figure out their amount. Instead of 500000000000, it would be 500,000,000,000.

First Time User - Password Requirements

User doesn’t know the password requirements and can’t move forward with using the Lamden wallet.

Possible solution - content to tell the user the password requirements in the error message.

Manage Holdings

I worry that the holdings don’t look clickable to the average user. I suggest following this wireframe or I can give you a higher fidelity version if that helps.

UX: Icons in Menu

Describe the bug
As a user, I want to be able to see icons in the menu that are clear and obvious what they lead to. For instance, Lock Wallet should be an icon of a lock. It's confusing that both "Lock Wallet" and "Backup and Restore" are both icons of cogs.

To Reproduce
Open menu

Screenshots

Stamp limit exceeded?

Limit was 100, failed and used 1000?

Create new addresses and send transactions

If the user would be able to create new (ethereum or bitcoin) addresses and send transactions he could use LamdenSwaps as a fully functional wallet. This would increase the usability and security as there would be no need to import an existing private key.

UX: Adding Coin

Describe the bug
As a user, I want to clearly and easily add new coins to my Lamden wallet. When I select a coin, I lose the ability to add a new coin. I wish that the add coin button will always be visible at the bottom instead of disappearing.

To Reproduce
Navigate to Clove wallet
Notice that you can add a coin
Select a coin that's already in your wallet
The Add Coin button disappears

Screenshots

Lamden Wallet freezes when clicking on History tab

The wallet will stop responding when clicking on History tab. Wallet will work again when you refresh the page and input your password again.

Improve transfer between accounts

If there are multiple accounts in the wallet, people often need to transfer coins from the main account to other accounts.
The UI in the wallet should be improved to move coins between the account without need to copy the destination address every time. This would improve the usability.