lamaparbat / herald-api-server Goto Github PK

• attempts count doesn't work for more than one user
• unmatched password is not registered to attempt counts
• only registers if both email and password is incorrect

• routines/ongoing should response all ongoing classes.
• routines/ongoing?group=:groupCode should response ongoing classes of that group.

Convert the two already made API into a single API .

1. Get routine by Level.
2. Get routine by Group.

You can see these two API in github documentation .

Task: use params to send the payload in this way; /searchRoutine?level=5&group=8&time=10am

/routines api should only accept one parameters i.e group.

when I tried to sign up as teacher it showed me this error in console

Change attribute of name group to groups as group indicates array of string.

1. The response is misleading because it says ("routine deleted successfully") even when its not deleting any routine
   

1. validate with day fullname like (Sunday , Monday) not (Sun or Mon)
2. Create DAYS array inside routine constant
3. implement validation inside routineAuth

Any one can create account by simply calling the url. Frontend will check the security to minimize the request call but we too have to implement it to minimize the risk incase of api url being leaked.

Notification imported from notifications.routes.js but 's' is missing at the end of the notification in development server.

Please follow the following steps:

1. Explain the project briefly
2. Mention the features and used technologies
3. Explain the project security and all strength part
4. Now, explain the code line by line and dont forget to insert the each explained part code in proper format

For documentation styling, please prefer this site: https://www.makeareadme.com/

Tested from swagger docs:

@BishalDali @RohanKumarMainali test and verify the change .

1. Status code is OK in bad request (ReportLostFoundData) endpoint
   

I guess its time to update the api docs.

1. The response says "routine updated successfully ! " even when routineID is incorrect
   

A new api endpoint which will accept a excel file to add schedule in bulk.
Attach the sample schedule file here after it's implementation.

I think the way of giving params is not correct. because i tested the same way in postman like this

please update the response structure on the swagger documentation part.

API Endpoint: https://dev-herald-server.herokuapp.com/api/v4/admin/updateRoutineData/
When we try to update routine it responds with error:

{
    "success": false,
    "message": "This group has another class in this time"
}

• /student endpoint should return list of all student.
  This endpoint should contain various filters like:
• courseCode
• level
• group
• name

Guys we are having issues on notification enpoints. Please try to find what has happened ?

The response is misleading so validate routineID before updating

Admin authentication repeated instead of student

1. Add extra Constants

• Routine Status =. ["Running", "Upcoming", "Cancelled", "Postponed", "Completed"]
• Course Type = ["BIT", "BIBM","MBA"]
• Block Name = ["HCK","WLV"]

2. Course Type Validation on Post routine api
3. Encapsulate all datas

Remove that reverse scope part and resend the pr

And remove the axios example, and set only one response object in array which you can compare between this screenshot image and swagger existing docs

There is requirement of getting section wise routine which haven't being implemented. Let's work on it.

Try to do destructuring.

Instead of doing this.

Do this

1. It doesn't check for a valid routine Id
2. Does not check if the payload is provided or not