laginha / yard Goto Github PK

In a resource, defining the fields attribute, something like this:

fields = ('name', ('author', ('name','gender')) )

won't work properly. However, everything works fine if you do:

fields = ( ('author', ('name','gender')), 'name' )

The problem lies in the build_json_tree algorithm within yard's resources.

Imagine the scenario where a Resource can only have one of the attributes:

from yard.resources.decorators import validate
from yard import forms, resources

class Dude(resources.Resource):
    class Parameters:
        full_name = forms.CharParam()
        short_name = forms.CharParam()
        __logic__ = full_name | short_name

    @validate
    def index(self, request, params):
        if 'full_name' in params:
            print 'Dude can write his name: {}'.format(params['full_name'])
        else:
            print 'Need to find full name of Dude called {}'.format(params['short_name'])

Now imagine you call http://api.example.com/dudes without providing none of the parameters... It crashes when you try to do the params['short_name'], with KeyError at /dudes/ 'short_name' as its cause. It means params.is_valid()in the decorator @validate (yard/resources/decorators.py) is returning True, which means there's something wrong with the class OR in yard/forms/parameter.py.