Param returning empty string about echo

[vishr]

From the example, createUser handler doesn't accept param.

[tekknolagi]

I've modified the handlers like so:

e.Get("/users", getUsers)
e.Get("/users/:id", getUser)

e.Post("/users", createUser)
e.Post("/users/:name", createUser)

but now get a Method Not Allowed. If I comment out the /users/:id route, it works.

[vishr]

Can you paste the full code and how you invoke the endpoint?

[tekknolagi]

https://gist.github.com/e168fc8fe9be985901fd

[vishr]

e.Get("/users/:id", getUser)
e.Post("/users/:name", createUser)

With current implementation, above is registered as conflicting routes, so if you change :name to :id, it should work. Let me know your thoughts.

Conflicting routes are captured in #3

[tekknolagi]

Is it possible to do this without a pretty URL? Just /users?name=joel?

Since

e.Get("/users/:id", getUser)
e.Post("/users/:name", createUser)

should not be conflicting routes.

[vishr]

Based on this example https://golang.org/pkg/net/url/#example_URL

c.Request.URL.Query().Get("user")

[tekknolagi]

@vishr I'm not sure what you are trying to say.

I meant that in most other frameworks, those two routes are distinct.

I unfortunately still get an empty string.

[tekknolagi]

https://gist.github.com/471fb336acb72f02d726

[vishr]

Just realized, it won't work. I will work on fixing the implementation to accommodate this scenario.

[tekknolagi]

Including the duplication of routes?

[vishr]

Duplicate routes like below will be covered in #3

e.Get("users/:id")
e.Get("users/:id")
e.Get("users/:name")

[tekknolagi]

Now I just cannot connect to port 8080 (with the same code).

[vishr]

I tried your original code https://gist.github.com/e168fc8fe9be985901fd for all the registered routes. Output below:

➜  tmp  curl -X GET localhost:8080/users
{"1":{"id":"1","name":"Wreck-It Ralph"}}
➜  tmp  curl -X GET localhost:8080/users/1
{"id":"1","name":"Wreck-It Ralph"}
➜  tmp  curl -X POST localhost:8080/users
{"id":"2","name":""}
➜  tmp  curl -X POST localhost:8080/users/Joe
{"id":"3","name":"Joe"}

Did you update Echo to latest?

[tekknolagi]

I thought I did update, but I could be wrong. How should I go about updating?

[vishr]

http://labstack.github.io/echo/guide/#installation

[tekknolagi]

Alright, I've upgraded. With the same code, though, I get an empty string when supplying data like so:

curl -X POST --data "{'name':'maxwell123'}" localhost:8081/users

Perhaps I am doing this wrong.

[vishr]

@tekknolagi I see in your curl command you are not sending Content-Type header, context.Bind currently only supports JSON. I am not sure but looks like JSON also needs to be in double quotes. Below is the working example

package main

import (
    "net/http"

    "strconv"

    "github.com/labstack/echo"
    mw "github.com/labstack/echo/middleware"
)

type user struct {
    ID   string `json:"id"`
    Name string `json:"name"`
}

var users map[string]user
var nextid int

func init() {
    users = map[string]user{
        "1": user{
            ID:   "1",
            Name: "Wreck-It Ralph",
        },
    }
    nextid = 2
}

func nextUserId() string {
    var next = nextid
    nextid++
    return strconv.Itoa(next)
}

func createUser(c *echo.Context) error {
    u := new(user)
    if err := c.Bind(u); err != nil {
        return err
    }
    u.ID = nextUserId()
    users[u.ID] = *u
    return c.JSON(http.StatusCreated, u)
}

func getUsers(c *echo.Context) {
    c.JSON(http.StatusOK, users)
}

func getUser(c *echo.Context) {
    c.JSON(http.StatusOK, users[c.P(0)])
}

func main() {
    e := echo.New()

    e.Use(mw.Logger)

    //--------
    // Routes
    //--------

    e.Get("/users", getUsers)
    e.Get("/users/:id", getUser)

    e.Post("/users", createUser)
    e.Post("/users/:name", createUser)

    // Start server
    e.Run(":8081")
}

curl -X POST -H 'Content-Type: application/json' --data '{"name":"maxwell123"}' localhost:8081/users
{"id":"2","name":"maxwell123"}

[tekknolagi]

Ah, okay. This looks like it should work now. Thank you!