Coder Social home page Coder Social logo

Comments (6)

aldas avatar aldas commented on May 18, 2024 1

probably some optimization etc. As Request.Host is always filled there is no point to populate Request.Headers map with that value and use additional memory. Also if it is not guaranteed to exists as HTTP/1.0 does not require that header.

from echo.

aldas avatar aldas commented on May 18, 2024

c.Request().Header.Get("Host") is not something that Echo touches. I assume that Go standard library HTTP server does not set Host into header as that same thing is in Request.Host field

from echo.

danthegoodman1 avatar danthegoodman1 commented on May 18, 2024

I guess we could add middleware to actually set it back, but it seems incorrect (whether at the go level or echo) that it wouldn’t be set properly?

from echo.

aldas avatar aldas commented on May 18, 2024

If you search Golang github you probably find answer there. I doubt you are first person to ask the same question. Also Request.Host field has comments. Probably in some situations you can do request without host header (probably HTTP/1.0) and it is deduced from the request url.

from echo.

Hades32 avatar Hades32 commented on May 18, 2024

golang/go#14239 just "won't fix" weird...

from echo.

aldas avatar aldas commented on May 18, 2024

I am closing this issue as I believe there nothing to fix/change from Echo side.

from echo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.