consumables's Issues
Recipes MVP
Functionality
- Scroll user to top of the page when they click on a recipe
-
Publish
button/link in the nav bar should bring you to recipe creation - Deleting recipe seems to have an error. (
Uncaught Error: Given action "RECEIVE_RECIPE_ERRORS", reducer "recipes" returned undefined.
)
CSS
- Project index should not contain favorite and starred
- Title and author should be underlined when
onHover
- Modal for creating recipe should be slightly lower
Let me know if you have any questions about these changes! I will revisit the CSS portion once you have steps in!
Frontend/Backend Routes
Frontend Routes
-
recipe/recipeId
should berecipe/:recipeId
. Use the:
to denote the wildcard since this is looking at a single instance of a recipe.
Backend Routes
-
No need for
steps
,images
,videos
routes. We will fetch that information with therecipe
and then use jbuilder to format the data. This is because steps are entirely dependent on the recipe. If this gets unwieldy we can break it up but it should be fine. -
No need for
GET
routes forcomments
since we will pass that up when fetching a project as well. -
Include a search route. If you want to search based off of optional params to an existing route (ex. index) then that is OK as well.
Let me know if you have any questions or want to talk about these changes!
Schema
Users
- Typo on
unique
for first point - Supplies could be contained in the body, if you want to ability to search by supplies then consider making a tags table. This can be done as a bonus!
Misc
-
Comments
,Photos
,Videos
have repeated bullet points. Make sure the column you are referencing exists in table.
For videos/photos we will ultimately be using AWS/Active Storage to host our photos so they will not need a url
column. More about this when we have our one-on-one since this is a late MVP.
Let me know if you have any questions about these changes!
User MVP Review
Great work! Functionality is good, here are some changes:
CSS
-
Login/Signup
and search bar should be adjusted slightly to make it match the original app. Use the inspector to see how you should adjust it. - Put
Demo Log
above theLogin/Signup
forms to match the links for Google/Facebook. Consider changing the color too to match those buttons. - Add a space between
member?
andLogin
inAlready a member?Login>>
for the session form. - Errors should be larger and matching original app.
- Add motto/tagline over home splash image to match original app.
Let me know if you have any questions!
Sample State
-
recipes
should have an array of steps. Making a request for a recipe should also bring up relevant steps data. We can store it in the array for reference if we ever need to count the steps or anything. -
We don't need steps for multiple recipes at once since you can only view steps if you are looking at the recipe. Our steps slice should only hold the relevant information regarding the current recipe that we are looking at. If you go with this approach, you could leave out the steps array.
Let me know if you have any questions or if you want to talk about this change.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.