Comments (7)
@Liooo @windard
Sorry for late.
I think I know the cause. But it is too difficult to be fixed by just me.
This linter is checking to see if the pointer of a loop variable is being brought into an external variable, but the check stops at where the "pointer is assigned to a variable".
If the destination of the assignment is an external variable, this linter can detect it, but as long as it assigns a local variable in the loop to its counterpart, it is assumed that there is no problem (negative).
A sample for positive:
var results []Result
for _, v := range iteratee {
results = append(results, Result{v: &v})
}
results
is an external variable. Assigning to it in one-statement, &v
is found.
exportloopref
does not track how the value of that local variable is subsequently handled.
In this case, the value placed in the local variable is then assigned (as a result of being appended) to the external variable, which should be detected as a problem.
However, tracking the subsequent treatment of the local variable requires recursively reanalyzing ast once analyzed, which is somewhat expensive and creates the need to track all assignments.
Currently, it is possible to analyze the ast in 1-pass, and if multiple analyses are required, such as 2-pass and 3-pass, the process of this linter will become heavier and heavier, so for my part, it is difficult to judge whether it is feasible or not.
Of course, it is possible to cover n assignments at most, as in the construction of struct, but I do not have a basis for determining a good upper limit.
CONCLUSIONS:
- If anyone knows how to track such assignments in 1-pass, a Pull-Request would be greatly appreciated.
- If anyone can analyze what kind of performance problems 2-pass, 3-pass, or n-pass would cause, please provide a good upper bound with benchmarks so I can adopt it.
from exportloopref.
Even public fields are not detected.
type Result struct {
V *string
}
var results []Result
for _, v := range []string{"a", "b", "c"} {
r := Result{V: &v}
results = append(results, r)
}
from exportloopref.
@kyoh86 plz take a look.
from exportloopref.
okay, I'll check it out.
from exportloopref.
How about provide a strict mode that not allow use any loop var ref. It's simple and easy although violence and rugged.
from exportloopref.
@Me1onRind If you want it, you can use looppointer
instead.
from exportloopref.
Related Issues (14)
- fails to find out what scopelint does HOT 7
- Linter throwing Panic HOT 7
- False positive when a loop var is exported, directly followed by break HOT 5
- False positive when exporting a pointer to a loop variable field. HOT 1
- False positive when ranging over a slice of pointers HOT 1
- take sliced arrays into account
- No reports about using variable on range scope in function literal (deprecated `scopelint` finds it perfectly) HOT 1
- Forbid captured loop variables HOT 3
- panic in checkUnaryExpr HOT 4
- exportloopref may be able to check decendants member like `a.b.c.d...`
- Suggest fixes
- golangci-lint fails on exportloopref for go v1.13 HOT 3
- Any benefits compared to gosec and scopelint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exportloopref.