fails to find out what scopelint does about exportloopref

[kyoh86]

It is not supported with exportloopref.
I want to make exportloopref as accurately as possible.

[siddharth178]

I thought scopelint checks will be available in exportloopref and I find check done on above code by scopelint important. It would really help if you could give some more context on why that kind of check is not part of exportloopref. @kyoh86

[kyoh86]

I found that diagnostics are just noise while a lot of false-positives are included.

• Any analyzer CANNOT know if a closure is called soon.
• So any variables in closures in the loop will be reported.

For example, scopelint reports a diagnostic on testcase.expect:

for _, testcase := range []struct {
	title string
	expect int
} {
	t.Run(testcase.title, func(t *testing.T) {
		actual := FUT()
		if testcase.expect != actual { // !!
			t.Errorf("
		}
	})
}

but it's not a problem (false-positive).

[kyoh86]

see also: kyoh86/scopelint#16 (comment)

[siddharth178]

Thanks @kyoh86 for the details!

[ziccardi]

@kyoh86 I think your example code should be reported at least as a warning.

While it is true that it is not an issue with your code, if you would just add t.Parallel() at the beginning of the test function it won't work anymore.

[kyoh86]

I could not found them without false-positives.
You can propose an implementation by pull-request.