kyleleneau / jmonthcalendar Goto Github PK

I have an application where I just want to process an event click in
javascript. In that the URL component is blank. If I do this when
clicking an event the browser scrolls upwards.

To fix this I changed the javascript to not add the href attribute when a
URL value is blank:

var link = "";
if (event.URL.length > 0){
link = jQuery('' + event.Title + '');
}else{
link = jQuery('' + event.Title + '');
}

What steps will reproduce the problem?

1. View demo for 1.3.0 beta
2. Click on a day

What is the expected output? What do you see instead?
Alert will display the last day of the month instead of the day that was
clicked

What version of the product are you using? On what operating system?
1.3.0 beta

Please provide any additional information below.
1.2.2 is working correctly

//DateBox Events
var dateLink = jQuery('

        var dateBox = jQuery("<td></td>").attr(atts).append(dateLink).dblclick(function(e) {
            defaults.onDayCellDblClick(new Date($(this).attr("date")));
            e.stopPropagation();
        }).click(function(e) {
            defaults.onDayCellClick(new Date($(this).attr("date")));
            e.stopPropagation();
        });

Think that gets it.

What steps will reproduce the problem?

1. Add this to the jscript options for the calendar:
   onDayCellDblClick: function(dateIn){
   alert(dateIn.toLocaleDateString());
   return false;
   },
2. Double click an empty date on calendar.

What is the expected output? What do you see instead?
Expected: The date of the day clicked.
Actual: The last date in the calendar

What version of the product are you using? On what operating system?
1.3.0 Beta

Please provide any additional information below.

*** POTENTIAL SOLUTION ***

This bug occurs because of variable scope. In JMonthCalendar there is a
loop which loops between the cells to render the days. At the start of the
loop the current date is set:
Line 297: var currentDate = _dateRange.startDate.clone().addDays(i);

Then later on the double click function is set:
var dateBox =
jQuery("").attr(atts).append(dateLink).dblclick(function(e) {
defaults.onDayCellDblClick(currentDate);
e.stopPropagation();

However the date passed is the date from the loop, which is ok for
rendering elements but not ok when the actual date is clicked because it
currently uses the last value currentDate was set to, which is the last day
on the visible calendar. To fix this the date needs to be extracted from
the element that initiated it by parsing this value:

$(this).attr('date')