kybernetwork / kyberswap

Codebase for KyberSwap that helps users convert tokens instantly and directly from their own hardware wallets, metamask and so on. No setup, No deposit, no withdrawal needed. Try it out on https://kyberswap.com or join telegram for developers https://t.me/KyberDeveloper.

KyberSwap: Instantly Convert Your Tokens

KyberSwap allows users to directly interact with Kyber's decentralized liquidity network and instantly swap/ trade their tokens. Check our website at https://kyberswap.com

Install dependencies

The wallet is developed on Nodejs, we assume users have it installed in their environment. We suggest to use Node v7.3.0

npm install

Run in development mode (ropsten network)

npm run ropsten

Once it is running, user can access to the wallet by going to http://localhost:3002

Build production app

npm run build-production

Code structure

This repository is using Reactjs and Redux and following their naming conventions. Source code of the wallet is in src. Most of the logic is in src/js.

Migrate media data

bundle exec rake master_data:media_post

Deploy staging:

git tag -f deploy_staging
git push -f <origin/upstream> deploy_staging

kyberswap's Issues

Have a mini button to allow instant copy of wallet address

Works like "copy link" button on Google Drive.

Could the UI be responsive?

Any chance the UI could be responsive to be usable on different resolutions and mobile phones?

It seems to me there is nothing really stopping this from happening. Issue is mostly in the use of fixed width layout which at least could be modified to collapse through media queries.

Bad GUI in select

In FF, select display is not good, please also re-style for select

The container is not big enough

UI issue when estimating the value between pairs

In the exchange page enter the following values:

DGD: 1.2341110

the estimate value in ETH will be:
ETH: 0.000000000000

If you change the last digit to:

DGD: 1.2341111

the estimated value in ETH will be:
ETH: 0.673446601147

It seems that if the last digit is 0, the estimated value will be 0.

css improvement of quick send page

Back & Next button is not middle aligned with left & right arrow .

Chrome browser, Version 60.0.3112.101 (Official Build) (64-bit)

Ask users to download his keystore immediately after a new account is created

I created the wallet, by giving account name and password. When I wanted to access a while later, it asked me to "import". But to my surprise, the "import" required keystore file and account name. By the time I created the wallet, I wan not aware where is the keystore file. So I cannot access the wallet any more.

Confirmation before delete account/wallet

when delete is clicked, whole wallet disappeared without a way of retrieval. It would be better if there is a form for users to confirm before actually delete the accounts/wallets.

Ether should be represented in the same way as other tokens

用谷歌浏览器出现网页崩溃

用谷歌浏览器出现网页崩溃

Rate table should be repositioned

Maybe we can have a separate tab for it.

the whole interface doesnt scale to fit the screen

download key doesn’t work also FF

Add password strength when user create account

Payment related features

Account setting should close after user clicks on it

CSS issue in create account page

Refer the screen shot in attachment.

Environment:
Safari, Version 10.1.1 (12603.2.4)

用户名重复被创建无响应问题

创建钱包页面无反应，更换用户名才可以完成创建，可能因应户名已存在，自己创建用户名重复所导致。

LocalStorage cause different browsers have different data

Currently, all data are stored in localStorage of browsers. Therefore, if I open FF/ Chrome, I'll have different data. In addition, user often clear cache, localStorage, this cause data loss. How about idea store data in local files?

several crash wallet

When i testing wallet, several minutes, Web will crash.

account/wallet actions (exchange, send) should be somewhere else

ether cannt input float number

while sending ether, i cannt input float number

Global control (+ button) display weird on Mac OS X

On Mac OS X, I used both Chrome and Safari, (+) button or global control not display correctly for online version https://testnet-wallet.kyber.network/. On Windows it's displayed normally.

I tried to run a local version, it's run fine. You can see results in the attached image.

My transaction history is lost after change browser

When i changed my browser to chrome, my transaction history is lost, same jsonfile, only account name is different.

Should give failing reason at the final step

Auto input passphrase

Auto input passphrase, this is unsafe.

Should add data (message) along with token in send feature

Broadcasting forever without any errors

The screen shot is the last step of sending GNOSIS to ETH address.
It should be as below:
[Transaction
xxxxxxxx
is waiting for confirmation...]

download key doesn’t work on FF

Browser autocomplete makes the password incorrect

1. if user manually do a transaction typing my password, no issue
2. if user select the pwd from autocomplete list, it shows "incorrect password". Even if he types his correct password afterward.
3. and if after 2 the user comes back and FORCE input the gas price to 2000000000 then type manually his pwd and it works.

add a readme

Add feature sort/search account/ wallet by name, ether, date created

Wallet Send ETH only can input Integer Not Decimal

When I send eth to others , I must send 1 or 2 or 3 or 4 .... .ETH to other wallet.

I can't send 3.4 ETH decimal number.

Stuck at broadcasting tx screen

In case there is an error when it is trying to broadcast the tx, the screen is stuck.

Expected behavior: Error should be shown so users know it's failed.

Should add multi accounts when deploy wallet

User should be required input passphrase when download keystore

Currently, When user click download keystore, it download intermediately, It is less secure for wallet app. May be we require users input passphrase when they want download keystore. In addition, Is it secure when when store keystore in localStorage of browser?

transaction failed 4 times

transaction failed 4 times on test network, is it supposed to be failed on a test network??

网页钱包在1366*768分辨率电脑模态框显示不全

![image](https://user-images.githubusercontent.com/15084789/29249481-ef9d061e-8062-11e7-888a-66434ec49d7a.png
以上是网页截图

Show input information before users type passphrase

• We should show general information user input. After that, they can decide whether to process transaction.
• In the last step, I think we should not allow press enter to process transaction, and not use -> button to confirm transaction (because it is navigate button). We should use button with text like "Confirm"

cannot import keystore

Cannot import keystore that is generated by MEW

would be useful if current block number can be shown just for reference purposes

suggest open links in new window --- https://testnet-wallet.kyber.network/info

suggest open these links in new window:
https://testnet-wallet.kyber.network/info

CSS issue in create account page （previous issue #77）

Previous issue #77 has been fixed, but it seems the font-size of "Type in your passphrase" is different with "Retype your passphrase".

Environment:
Safari, Version 10.1.1 (12603.2.4)

open transaction link in new window

suggest to open the transaction link in new window.

Removal of leading and trailing spaces when pasting a wallet address to send to

As the title says, useful to avoid the invalid address messages in many of the cases.

There is no way to modify passphrase/password for a wallet

It'd be great to be able to modify password, but I don't think there's a way to do it yet.

Can not send ether when input address uppercase

In quick send modal, when input send to address: 0Xf12bccb65addf0432157cb262134412b9f237848.

In last step, when input password and press enter, It shows error: Your password is incorrect. Normally, It should process transaction

rate window does not show the volume available for that particular price

Modify accounts/wallets doesn't work

Send window disappears if user hit enter after specified addresses

Overall idea is to support Enter to go to next step. Right now, if users specify to address and hit Enter, the window will disappear.