kyanny / compare_linker

Create GitHub's compare view URLs for pull request from diff of Gemfile.lock (and post comment to pull request).

This repository is no longer maintained.

Plealse check https://github.com/masutaka/compare_linker instead.

compare_linker's Issues

Wrong "downgrade" detection

useragent: josh/[email protected] (downgrade)

SSH URL is not supported in LockfileComparator.compare method

Issues:

SSH URL is not supported in LockfileComparator.compare method

• HTTPS URL：supported
  https://github.com/owner/gem_name.git

• SSH URL：not supported
  [email protected]:owner/gem_name.git

→ Can not read remote URL in the following cases ...
Gemfile.lock:

GIT
  remote: [email protected]:owner/gem_name.git
  revision: 3a748332bade386c88..........
  branch: master
  specs:
    XXXXX (1.0.0)

Code:

compare_linker/lib/compare_linker/lockfile_comparator.rb

Line 16 in cc5c7b2

_, owner, gem_name = old_spec.source.uri.match(/github\.com\/([^\/]+)\/([^.]+)/).to_a

Regular expression modified code:

/github\.com[:\/]([^\/]+)\/([^.]+)/

Release to rubygems.org

Hi kyanny-san,

Will you release to https://rubygems.org?
I want to use in my gem. But can't write the following...

spec.add_dependency 'compare_linker', github: 'kyanny/compare_linker'
# or
spec.add_dependency 'compare_linker', git: '[email protected]:kyanny/compare_linker.git'