kward / shlib Goto Github PK

test_runner removed all references to the th_* functions (error,warn,etc)

it still contains one call to th_error
th_error

This should be replaced either by new runner_error function or using existing runner_fatal or runner_warn functions.

See shUnit2 for a start.
https://github.com/kward/shunit2/blob/master/shunit2#L83

/etc/lsb-release is not suitable for SLES, either it does not exist (11.4/12.*) or it contains just crap (>=11.3)

instead /etc/os-release should be used (applies also for all other distributions)

PRETTY_NAME="Red Hat Enterprise Linux Server 7.4 (Maipo)"
PRETTY_NAME="SUSE Linux Enterprise Server 12 SP1"
PRETTY_NAME="SUSE Linux Enterprise Server for SAP Applications 12 SP2"
PRETTY_NAME="SUSE Linux Enterprise Server 11 SP4"

releases before SLES11.4 contain only /etc/SuSE-release

cat /etc/SuSE-release
SUSE Linux Enterprise Server 11 (x86_64)
VERSION = 11
PATCHLEVEL = 3

See the test output of https://travis-ci.org/kward/shflags/jobs/289911880 for an example.

testrunner searches for *_test.sh files only in local directory.

Test in subdirectories should also be executed.

Reported by @Pitterling.

standalone/test_runner lines 137-146.

  # Execute the tests.
  for suite in ${tests}; do
    # shellcheck disable=SC1117
    suiteName=$(expr "${suite}" : "${TESTS_PREFIX}\(.*\).sh")
    echo
    echo "--- Executing the '${suiteName}' test suite. ---"
    # ${shell_bin} needs word splitting.
    #   shellcheck disable=SC2086
    ( exec ${shell_bin} "./${suite}" 2>&1; )
  done