kvnlay / facemash

A social media app built with ruby on rails. It includes some of the core features of the facebook app which includes; users, friendships, posts, liking, comments, etc.

kvnlay

My Github page

facemash's Issues

[Accepting friend request doesn't make the two friends]

I think we need to fix your implementation of creating friendships out of an existing friend_request.

Steps to recreate:

1. Create two users - ryto and jim
2. Run jim.sent_requests.create(requested_id: ryto.id)
3. Run ryto.friends -> Shows jim in it.
4. Run jim.friends -> Shows empty array.

This means

remove_friend method in user model using current_user method

This method is using another method inside it which the User model is unable to access. In the console I am trying to do the ff:

ryto.remove_friend(first) -> ryto and first are users I created and they are friends

But this results in the ff:

I also figured you didn't include this remove_friend method in your user_spec.rb specs. So yes we should also test this.

Two friendship records created for every user becoming friends with another

Hi,

I didn't right away realize this but since for the past projects I've reviewed this has been happening. I was wondering if you can refactor the way you generate friendship records in the database:

ryto.friendships.create(friend_id: first.id) and then running Friendship.all shows:

I recognize that this is due to the create_mutual_friendship method you have in your Friendship model. However, doing it like this can easily fill up the database with unnecessary records. What we want is just to record a friendship once (and in fact enforcing uniqueness in the friendship between two users).

A way to do this is to keep track of which user adds the other. Similar to how you did it with FriendRequest (in here for every request made there is only one record generated).