kuzat / screenshot-node Goto Github PK

I think there's a memory leak on OSX; each screenshot's image data is allocated in memory but not freed

In prtscn_osx.mm

void getScreen(const int x, const int y, int W, int H, const char* path) {
        ...
  CGImageRef image_ref = CGDisplayCreateImageForRect(CGMainDisplayID(), rect);
  CGImageWriteToFile(image_ref, [NSString stringWithUTF8String:path]);
}

The image reference should be freed after its no longer needed.
Referring to the developer docs
https://developer.apple.com/documentation/coregraphics/1454595-cgdisplaycreateimageforrect

The caller is responsible for releasing the image created by calling CGImageRelease.

It should be

void getScreen(const int x, const int y, int W, int H, const char* path) {
  ...
  CGImageRef image_ref = CGDisplayCreateImageForRect(CGMainDisplayID(), rect);
  CGImageWriteToFile(image_ref, [NSString stringWithUTF8String:path]);
  CGImageRelease(image_ref);
}

Is there a way to save the image as a buffer in a variable and not in disk?

I have to compile manually because I work with nwjs
nw-gyp rebuild --target=0.42.5 --arch=ia32
https://prnt.sc/q1ze7n

I think, your code is compatible for nodejs 4.x, can you code to 10.x? But I am not sure about that.

I have noticed that we can save the images in only png format. Can other formats be supported?

There is no multi monitor support as of now. It should probably be implemented.