kusalananda / shell-toolbox Goto Github PK

I've just tested 'develop' branch and find an interesting issue. Without parameters shell returns these shells:

Valid shells:
	/bin/sh
	/bin/bash
	/sbin/nologin
	/usr/bin/sh
	/usr/bin/bash
	/usr/sbin/nologin

Of cause regular expression ("/$shell$") in line 116 doesn't works in this case (I've added echoing for testing):

[yurij@centos7 bin]$ ./shell bash
Realshell: /bin/bash /usr/bin/bash
shell: No such shell: bash
Valid shells:
	/bin/sh
	/bin/bash
	/sbin/nologin
	/usr/bin/sh
	/usr/bin/bash
	/usr/sbin/nologin
[yurij@centos7 bin]$ ./shell /bin/bash
Realshell: /bin/bash /usr/bin/bash
shell: No such shell: bash
Valid shells:
	/bin/sh
	/bin/bash
	/sbin/nologin
	/usr/bin/sh
	/usr/bin/bash
	/usr/sbin/nologin

There are at least two approaches possible in this case:

1. Fix regular expression;
2. In get_shells function (line 80) add one condition which checks that file is not symbolic link, because:

[yurij@centos7 bin]$ readlink -f /usr/bin/bash
/usr/bin/bash
[yurij@centos7 bin]$ readlink -f /bin/bash
/usr/bin/bash 

Can I contribute?
Interesting project. Thanks for this!

Are you sure this is what you want?

Isn't printf "%s" "$*" >&2 just fine here?

😄 Cheers!

I've just pulled devel branch, also reconfigure & make. Start it:

[yurij@centos7 src]$ ./shell
./shell: line 142: [: : integer expression expected
Starting /bin/bash in /tmp/shell-bash.BuwfbqXK
$ exit
exit
Removing /tmp/shell-bash.BuwfbqXK

Assume that keep variable need to set to zero before handle cmdline options.

Hello,

I just wanted to say that a FreeBSD port of shell-toolbox has been submitted and is awaiting review and approval.

I've tested shell on FreeBSD a little bit and I confirm it works.

Cheers!