kumojin / favicon-loader Goto Github PK

Update the nvm file and ensure the build is green

Currently, the getFavicon method does not allow changing the favicon provider, which is google.com by default. This could be changed by adding a second "options" parameter, so that we could call for example:

getFavicon('https://applecom'); // Uses the default google.com/s2/favicons provider
getFavicon('https://applecom', { provider: FAVICON_KIT })

Where FAVICON_KIT would be an enumeration value, along with GOOGLE.

We should be able to:

• build
• test (which does nothing now)

This one is a bit tricky as we're relying a lot on DOM to make the thing work 😬

The dependencies are a bit old now, we can update them to something newer, and also lock them.

Most notably: explain about the function failing Google s2 returns its default favicon (when the website has no favicon)

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Datasource	Name	Replacement PR?
npm	@babel/plugin-proposal-class-properties

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• ci(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• ci(deps): update dependency eslint to v9
• ci(deps): update dependency eslint-plugin-n to v17
• ci(deps): update dependency eslint-plugin-promise to v7
• ci(deps): update typescript-eslint monorepo to v8 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

from node 14 to node 18

The favicon size is currently hardcoded into the URL.