Coder Social home page Coder Social logo

Comments (5)

lbb avatar lbb commented on May 27, 2024

/fixes https://github.com/GoogleContainerTools/krew-index/issues/15

from krew.

ahmetb avatar ahmetb commented on May 27, 2024

I like the idea. I think it should not be a user-visible command that pollutes "kubectl plugin --help" surface. For example, brew audit is hidden by default. But I think we can't do that just yet.

How about making this a separate plugin that only plugin devs need to install? This way the audit can evolve/live independently.

On the CI side, I think we need a command that can download and install the plugin for ALL os/arch combinations. So something in the lines of:

<cmd> audit --source=<plugin>.yaml [--os=] [--arch=] [--target-dir=$KREW_INSTALL_PATH?]

from krew.

ahmetb avatar ahmetb commented on May 27, 2024

So we solved the --os/--arch customization with KREW_OS and KREW_ARCH in #70. Similarly, --target-dir= was solved in #65.

The primary challenge I'm facing right now is figuring out all the supported os/arch matrices from platform.selector to write a cmd that executes

KREW_OS=... KREW_ARCH=... KREW_ROOT=$(mktemp -d) krew install --source=<plugin.yaml>

to verify all platform urls/fileOps are working.

from krew.

ahmetb avatar ahmetb commented on May 27, 2024

Postponing to after v0.2.

from krew.

ahmetb avatar ahmetb commented on May 27, 2024

Fixed with #151 by adding a manifest validator tool.

from krew.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.