Comments (5)
I added a solution with respect to my proposal #833. Appending branch name with #
will set the cloned repositories default branch to the given one. It worked without any problem in my tests.
from krew.
it seems a little strange to me to handle this with different versions of the index. homebrew handles this by allowing versioned formulae in their main tap. i dont know off the top of my head if that is already possible with krew (i forget exactly what parts of the plugin spec are used to setup the binary installed in .krew/store
and the symlink in .krew/bin
). there are other things in addition to having separate plugins that would be needed though, like how to link a specific version.
i think your implementation makes sense for solving this by versioning the index (as long as that clone command properly sets refs/remotes/origin/{branch}
so that the git reset --hard @{upstream}
is referencing the correct remote), but im not totally convinced it should be handled there instead of supporting different plugin versions.
from krew.
it seems a little strange to me to handle this with different versions of the index. homebrew handles this by allowing versioned formulae in their main tap. i dont know off the top of my head if that is already possible with krew (i forget exactly what parts of the plugin spec are used to setup the binary installed in
.krew/store
and the symlink in.krew/bin
). there are other things in addition to having separate plugins that would be needed though, like how to link a specific version.i think your implementation makes sense for solving this by versioning the index (as long as that clone command properly sets
refs/remotes/origin/{branch}
so that thegit reset --hard @{upstream}
is referencing the correct remote), but im not totally convinced it should be handled there instead of supporting different plugin versions.
@chriskim06 thanks for your comments. I had a similar discussion on Slack with @ahmetb and he also had some concerns about supporting this in terms of maintainability and narrow audience.
I'm closing my PR due to this, I'll keep issue for a while in case someone else also need this;
/close
from krew.
I incorrectly closed issue :). Sorry for noise.
from krew.
/close
from krew.
Related Issues (20)
- Error: Flag --kubeconfig is not supported HOT 3
- Please release a new version HOT 4
- I have been struggling to install the OIDC-LOGIN plugin. I get Access is denied HOT 5
- Found some vulnerabilities in CVE report, when will it be fixed HOT 4
- Proposal: Download Binary File and Download License via URI HOT 6
- Krew seems to not download all the bytes of distribution archive HOT 2
- Proposal: kubectl krew list should not require a plugin index HOT 11
- $KREW_ROOT/store/<plugin>/* has wrong permissions, 0700 instead of 0755 HOT 14
- Remove Developer Mode / Admin requirement for Windows install by using junctions HOT 2
- stats.krew.dev is not updating HOT 2
- Allow installing without sha256 when using --manifest-url HOT 8
- Allow selecting all platforms HOT 6
- support uninstall with --manifest-url HOT 6
- Cross platfrom (Windows) install testing failing on Linux HOT 3
- Installing krew - failed to list indexes on Windows HOT 3
- krew fails to work if `defaultRemoteName` is assigned in ~/.gitconfig HOT 1
- Can we have krew plugin for x86 arch on prem ubuntu servers HOT 2
- It complains 0.4.4 is not supported anymore on maiden install HOT 6
- Can Krew be Installed as Super User (su)? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from krew.