Use plugin description in search command about krew

[ahmetb]

@nammn Feel free to work on a patch.

[lbb]

Yeah, we are currently not using the description for the search. We are only searching plugin names.

[ahmetb]

@orthros is taking a stab at this.

[nammn]

If its still free, i would like to take a look at this @ahmetb

[nammn]

great, i'll work on this patch 👍

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fabiand]

Any update on this one?

The new virt plugin is also affected by this (not found if searched for kubevirt).

[ahmetb]

/remove-lifecycle rotten

We'll probably get to it at some point. It's not a super high priority since most users probably find plugins through some github repo so they know its installation command.

[fabiand]

Ok. Would you be open to a PR?

[ahmetb]

We already had #150 but happy to give it another try. This might require some experimentation. Text search isn't a simple problem, and we might need to sanitize the input a little bit (e.g. to remove line breaks, figure out how to treat urls in descriptions and so on).

[danielpacak]

The same applies to the who-can plugin which does some reverse lookup in RBAC permissions. It won't show up when I type kubectl krew search rbac.

Did you consider adding the keywords property to the manifest spec? Something similar to what npmers are doing? https://docs.npmjs.com/files/package.json#keywords

name: "who-can"
keywords: ["rbac", "authorization"]

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[corneliusweig]

I'm unsure what to do with this issue. On the one hand #150 was closed long ago, but a search in description seems to be something that many users miss.
So I'd like to gather more input as to how an improved search functionality would be used. Let's put the technical details aside and just create a wish-list of workflows.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.