Coder Social home page Coder Social logo

Comments (9)

ahmetb avatar ahmetb commented on May 26, 2024 1

No prow here, also can't assign without adding you to org or transferring repo. 🤷‍♂️

from krew.

ahmetb avatar ahmetb commented on May 26, 2024 1

Makes sense. We don't connect to API so we don't need the restclient.

The only part that could've been useful is --output flag for kubectl krew list, and even in that case it would be severity/P2. We'll hold off on this.

from krew.

juanvallejo avatar juanvallejo commented on May 26, 2024

/assign

from krew.

ahmetb avatar ahmetb commented on May 26, 2024

What would we get out of cli-runtime if we migrated today (other than standardized flags)?

from krew.

juanvallejo avatar juanvallejo commented on May 26, 2024

What would we get out of cli-runtime if we migrated today (other than standardized flags)?

Mainly those. Which we could then use to obtain a "restclient config" we could then use to talk to the kube api using k8s.io/client-go. We'd get printing and other cli helpers as well. Not really sure to what extent Krew needs all of these today though.

from krew.

fejta-bot avatar fejta-bot commented on May 26, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from krew.

fejta-bot avatar fejta-bot commented on May 26, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from krew.

ahmetb avatar ahmetb commented on May 26, 2024

/close
For now krew doesn't need any of the packages offered by cli-runtime.

from krew.

k8s-ci-robot avatar k8s-ci-robot commented on May 26, 2024

@ahmetb: Closing this issue.

In response to this:

/close
For now krew doesn't need any of the packages offered by cli-runtime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from krew.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.