[SDK] Create Job From Docker API about training-operator

[terrytangyuan]

Yep exactly this will avoid exploding the list of public APIs.

[terrytangyuan]

+1 for ease of use. Although I would avoid mentioning "docker" which is implementation specific.

[andreyvelich]

Makes sense, any suggestions @terrytangyuan (e.g. create_job_from_image) ?

[terrytangyuan]

What about create_job(func, img) that calls underlying implementation?

[andreyvelich]

Makes sense, so just provide users 1 API called create_job where they can set Custom Resource, function or image and we are going to process the request accordingly, right ?

[tenzen-y]

It's a good idea. SGTM

In the future, we can introduce target_image, packages_to_install, etc. parameters which allows SDK to build Docker image on a fly using Docker client.
User requires to run docker daemon to use it.

In future work, it might be better to add parameters to define if push built image to the registry.

[johnugeorge]

/cc @gaocegege

[andreyvelich]

/assign @andreyvelich

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tenzen-y]

/lifecycle frozen