Coder Social home page Coder Social logo

Comments (9)

tenzen-y avatar tenzen-y commented on July 18, 2024 1

Sure, that sound great @tenzen-y! It would be great to see the benchmarks for mpirun and torchrun to run DeepSpeed on Kubernetes.

It sounds great, but I guess that there are no significant performance differences between both approaches since the deepspeed uses the NCCL backend even if we use mpirun.

from training-operator.

google-oss-prow avatar google-oss-prow commented on July 18, 2024

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Related: #2040

As we discussed multiple times, Kubeflow community are looking for examples on how to use MPI Operator and DeepSpeed.

We should add some example to the MPI Operator: https://github.com/kubeflow/mpi-operator/tree/master/examples/v2beta1 or Training Operator: https://github.com/kubeflow/training-operator/tree/master/examples.

Some pending PRs can be found here as reference:

/good-first-issue
/help
/area example

/cc @alculquicondor @kubeflow/wg-training-leads @kuizhiqing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from training-operator.

tenzen-y avatar tenzen-y commented on July 18, 2024

I believe that both (training-operator and mpi-operator) examples would be worth it. But, I think that we should add each example for PyTorchJob with deepspeed and torchrun, and MPIJob v2 with deepspeed and mpirun.

from training-operator.

andreyvelich avatar andreyvelich commented on July 18, 2024

Sure, that sound great @tenzen-y!
It would be great to see the benchmarks for mpirun and torchrun to run DeepSpeed on Kubernetes.

from training-operator.

vsoch avatar vsoch commented on July 18, 2024

I'm working on an equivalent example for the Flux Operator - but quick question. Will it work OK to test without GPU? I've been trying to get just 3 nodes, each with one nvidia GPU on Google Cloud, and I never get the allocation.

from training-operator.

vsoch avatar vsoch commented on July 18, 2024

Ah - this looks more promising. https://github.com/kubeflow/mpi-operator/pull/567/files

from training-operator.

andreyvelich avatar andreyvelich commented on July 18, 2024

@tenzen-y Does DeepSpeed only support nccl backend ? E.g. we can't run it with CPUs ?

from training-operator.

tenzen-y avatar tenzen-y commented on July 18, 2024

@tenzen-y Does DeepSpeed only support nccl backend ? E.g. we can't run it with CPUs ?

TBH, I don't have any experience only with CPU. But at the first glance, the deepspeed seems to support PyTorch without GPU: https://github.com/microsoft/DeepSpeed/blob/master/.github/workflows/cpu-torch-latest.yml

from training-operator.

kuizhiqing avatar kuizhiqing commented on July 18, 2024

that there are no significant performance differences between both approaches since the deepspeed uses the NCCL backend even if we use mpirun.

This statement is generally correct in almost all cases with NCCL context. Though, I've two few experiences to share for those using mpi-style set-up and suffering performance issue.

  • Avoid using mpi library(mpi4py e.g.) to do any collective communication, for some metrics collection etc., even if they only using TCP network.
  • DO NOT produce too much logs in mpirun scenario, the mpirun would collect logs from all the workers which may hurt the performance

Overall, mpirun and torchrun should have no performance difference.

from training-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.