Repository for kubeflow frontend
License: Apache License 2.0
Kubeflow the cloud-native platform for machine learning operations - pipelines, training and deployment.
Please refer to the official docs at kubeflow.org.
The Kubeflow community is organized into working groups (WGs) with associated repositories, that focus on specific pieces of the ML platform.
Please refer to the Community page.
This is the parent tracker for all bug bash related changes needed to be done
/area metadata
/area front-end
/priority p0
/assign @avdaredevil
/assign @kwasi
Feedback given by @neuromage after early demo. Cards look too similar and are hard to distinguish on certain screens.
@ajayalfred any thoughts on this?
/area metadata
/area front-end
/priority p1
/assign @ajayalfred
/cc @kwasi @avdaredevil
/area metadata
/priority p0
59cbf3d introduced a regression where resource descriptions were missing. Even though the PR would have required updating snapshots, the missing data would have been very noticeable in the empty descriptions.
We should add tests that handles older data where fields are in ArtifactProperties as well as newer data where fields are in ArtifactCustomProperties.
See https://github.com/kubeflow/metadata/blob/master/frontend/src/pages/ArtifactDetails.test.tsx and its import of testModel for how to construct an instance of the GetArtifactById response with the correct test data.
/area metadata
/area front-end
/priority p0
/assign @kwasi
/cc @avdaredevil
Where would it go? If the answer is to the first execution it was used in, then this task should wait until execution targeting support is added.
/area metadata
/area front-end
/priority p0
/assign @kwasi
/cc @avdaredevil
/kind bug
/area front-end
Screenshot: https://screenshot.googleplex.com/8PptgokgKXb
This may be partially a non-issue if the issue has been fixed in a later version
of the sample. The first investigation should be to try using a newer version:
https://github.com/kubeflow/pipelines/tree/master/samples/core/parameterized_tfx_oss
Either way, the issue of null titles showing up in the action bar as emtpy
spaces MUST be fixed.
/area front-end
Mentioned in the code review from: kubeflow/pipelines#2918
This would be an improvement because:
- there may be name collisions with other imports
- it's easier to find all client related imports
/priority p0
/area front-end
/assign @kwasi
It looks like downstream artifacts are connected to the first upstream execution only. See screenshot for sample TFX pipeline. All artifacts downstream of StatsGen and connected to StatsGen, which includes artifacts unrelated to StatsGen like transform_graph.
https://screenshot.googleplex.com/ey9TJBUYbS1
This issue was reported in the KFP bug bash so follow those instructions for repro.
This issue tackles the issue of execution cards being very similar to artifact cards in the UI.
/area metadata
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi
This issue is regarding the ExecutionName (type header) formatting exceeding the width of the card and overflowing
/area metadata
/area front-end
/priority p0
/assign @avdaredevil
/cc @kwasi
This issue is regarding the lineage view not fitting in most screens (width wise).
/area metadata
/area front-end
/priority p0
/assign @avdaredevil
/cc @kwasi
/area metadata
/area front-end
/priority p2
/assign @avdaredevil @kwasi
/cc @truptinayak
/priority p0
/assign @kwasi
/area front-end
https://screenshot.googleplex.com/VdqOaPagkkM.png
Current dependencies list include a few things not suitable there, like react, react-dom, react-scripts. They should be moved to dev dep and react should be peer too.
/assign @kwasi
/priority p2
This came up in code review for the pipelines integration:
kubeflow/pipelines#2918 (comment)
The ask is to move the package under @kubeflow scope so that imports are cleaner.
It also has the added benefit of this package not being confused with https://www.npmjs.com/package/frontend
/area metadata
/area front-end
/priority p0
/assign @kwasi
/cc @avdaredevil
This is feature request for ArtifactDetails which is a page within the Pipelines application, rather than shared component. Fixing it Pipelines won't fix it in every place where MLMD Lineage is being used so for the purpose of this bug it's enough to fix the is issue in Pipelines in the short term.
This issue is being filed in this repo and not pipelines to track finding a more long-term solution where the Artifact list shown on the ExecutionDetails page can be shared. This could be resolved by upstreaming the whole ArtifactDetails to be shared between metadata and pipelines, but that may require more time given that the page components generally expect routing params from the application.
<ArtifactLink /> component for URIs/kind bug
/area front-end
When rendering a <LineageCardRow/> for an Execution we always show a next and previous dot.
We should:
As of now I haven't gotten kubeflow/frontend to build successfully in both kubeflow/metadata and kubeflow/pipelines without running into conflicts with the way they both enforce TS config and style rules.
kubeflow/pipelines uses react-scripts-ts
kubeflow/frontend uses reacts-scripts vanilla
These are the ts configs:
https://github.com/kubeflow/metadata/blob/master/frontend/tsconfig.json
https://github.com/kubeflow/pipelines/blob/master/frontend/tsconfig.json
These config files are enforced by react-scripts-ts:
https://github.com/kubeflow/pipelines/blob/master/frontend/tsconfig.prod.json
https://github.com/kubeflow/pipelines/blob/master/frontend/tsconfig.test.json
This repo includes checked in ES5 code and points instead of compiling as a postinstall step.
NOTE: You have to run npm build after making changes in order for the changes to be reflected in dependent repos. npm run build:watch will allow changes to be reflected during development.
npm build as postinstallbuild/ to .gitignore and remove build artifcatsThis issue is regarding the ExecutionName formatting looking like a link, but not doing anything, we will snub out this behavior for this release, and consider making it selectable in the next iteration sometime in Q2-3
/area metadata
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi
/area metadata
/area front-end
/priority p0
/assign @kwasi
/cc @avdaredevil
/area metadata
/area front-end
/priority p0
/assign @kwasi
/cc @avdaredevil
This issue is regarding the subtext under each metadata row being workspace currently, and we'd like to change it to show run id instead. Reason being: Using Pipeline name as the description makes it hard to distinguish Runs involving the same Artifact.
Workspace_name -> run-id/area metadata
/area front-end
/priority p0
/assign @avdaredevil
/cc @kwasi
Right now, kubeflow/pipelines is the only maintained repo that depends on kubeflow/frontend.
If there are no further objections, I'll archive this repo and move content to github.comkubeflow/frontend about one month later.
I'll keep the directory structure similar and independent, so that in case there's a need to build reusable components again, we can pull them out. However, with current situation, it saves the most efforts if these components live directly in kubeflow/pipelines.
/cc @avdaredevil @jlewi
/kind bug
/area front-end
When rendering a <LineageCardRow/>we currently always show:
We should:
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.