Coder Social home page Coder Social logo

Comments (6)

fridex avatar fridex commented on June 1, 2024

For tcp, we should be sending KTLS_MAX_PAYLOAD_SIZE bytes, and returning the number of bytes sent

Sounds reasonable to transparently assemble records from kvec (simply by iterating over scatter/gather array passed) so user space does not have to care about it. I don't like the buffer approach, is it really needed here?

Nevertheless, I would consider to send payload based on MTU set by setsockopt(2) (which is KTLS_MAX_PAYLOAD_SIZE by default) for both, TLS and DTLS (for DTLS limit what can be sent).

The man page says it should be EMSGSIZE:

Return values have to be reviewed. To be honest, I did not give any special care to return values at all (https://github.com/fridex/af_ktls/issues/3).

from af_ktls.

lancerchao avatar lancerchao commented on June 1, 2024

OpenSSL[1] segments data into record buffers if size overflows.

[1] https://www.ibm.com/support/knowledgecenter/ssw_i5_54/apis/sslwrite.htm

from af_ktls.

djwatson avatar djwatson commented on June 1, 2024

fixed by #62

from af_ktls.

lancerchao avatar lancerchao commented on June 1, 2024

Why is this closed? #62 fixes recv partial data. It hasn't changed send.

from af_ktls.

fridex avatar fridex commented on June 1, 2024

Reopening...

from af_ktls.

djwatson avatar djwatson commented on June 1, 2024

implemented in #84

from af_ktls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.