Comments (7)
fridex
commented on June 14, 2024
I suppose that it occurs with TLS.
from af_ktls.
lancerchao
commented on June 14, 2024
The kernel has to validate user buffers before accessing them. copy_page_to_iter does this for you, but the decryption api does not.
from af_ktls.
lancerchao
commented on June 14, 2024
Tests available here.
https://github.com/ktls/af_ktls-test/blob/a84cbb8749505c0747859abe9e8c7c1a9ccb6416/tests.cpp#L483-L561
from af_ktls.
fridex
commented on June 14, 2024
why was this issue closed?
from af_ktls.
lancerchao
commented on June 14, 2024
Patch is available here.
[https://github.com/lancerchao/af_ktls/commit/fe9c547c39a46587324aabcee2894571b3897849]
Btw, it is not necessary in ktls with revamped buffer management since those keep decrypted data in skbuffs and never decrypts straight to user memory.
from af_ktls.
fridex
commented on June 14, 2024
I will take a look at your implementation ASAP.
Not to forget about this, reopening since fix is not available in ktls/af_ktls master.
from af_ktls.
djwatson
commented on June 14, 2024
Fixed, no longer needed now that using skbs
from af_ktls.
Related Issues (20)
- Test suite HOT 6
- new ciphersuite: chacha20-poly1305 HOT 1
- license is GPLv3
- Copy data from multiple TLS records to userspace buffer HOT 9
- Buffer changes HOT 6
- Crypto API scatterwalk copy HOT 2
- MTU handling HOT 8
- Allocating too many pages HOT 1
- Sleeping with lock held HOT 1
- possible lock inversion surrounding splice HOT 2
- Remove rx async work HOT 6
- Race condition in KTLS_RECV_READY HOT 2
- peek tcp data using tcp_read_sock HOT 2
- check sock_queue_rcv_skb return value HOT 4
- DTLS sliding window should always advance
- Investigate using a single FD
- DTLS window check needs to happen after decrypt
- Support async crypto API
- Paper might also wish to cite Plan 9's devtls as related work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from af_ktls.