krmaxwell / trx

Maltego library

TRX

Python library for Maltego transforms. Based on code from Paterva, available at http://dev.paterva.com/developer/downloads/ and reused with permission.

Build your own remote transforms!

trx's Issues

Generate XML programmatically

Instead of assembling by hand, use dicttoxml or similar to create XML in a more reproducible and readable manner.

Improve string concatenation

This is different from #3 in that we are dealing with the places where we do want to generate strings. Rather than just concatenating with str1 + str2, we should either use string interpolation (e.g. str.format()) or ''.join(str1, str2).

Refactor MaltegoEntity.displayInformation

Like #6

Add docstrings

Guide: https://www.python.org/dev/peps/pep-0257/

Refactor MaltegoTransform.UIMessages

MaltegoTransform.UIMessages should be a list of named tuples to improve readability. Sort of like a dict but more efficient and less prone to bugs in this use case.

Validate that everything is Unicode safe

I fixed some immediate pain in #2 but there still are a lot of str(varName) calls out there.

Make it Unicode-safe

Returning entities with non-ASCII values generates a UnicodeEncodeError.

Create test case for strict matching rules

Make sure we're testing all the branches for MaltegoEntity.returnEntity. While we're at it, probably do the same for MaltegoTransform.returnOutput.

Remove globals in MaltegoEntity

As previously done with MaltegoTransform - these can probably just be removed straight off.

Write basic tests

Set up testing environment and basic smoke tests.

TypeError in MaltegoEntity.returnEntity()

[-] Request for x.x.x.x of type IPAddress
[-] Fetching bare fundamental x.x.x.x => type specified was IPAddress
[-] Preparing Maltego XML
[+] Found 2 results
[+] Found malicious event: 65389c46-b2c4-462b-af5e-3c69c9c7a105
[+] Found intel alert: 6eb20c57-50af-46f3-9aa9-a85e2231d46d
[+] Writing Maltego XML
Traceback (most recent call last):
  File "/home/maltego/venv/local/lib/python2.7/site-packages/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/maltego/venv/local/lib/python2.7/site-packages/bottle.py", line 1732, in wrapper
    rv = callback(*a, **ka)
  File "scryingorb/debugTRX_Server.py", line 14, in fundamental
    ret_v = orb.trx_fundamental(TRX.MaltegoMsg(request.body.getvalue()))
  File "/home/maltego/scryingorb/scryingorb/scryingorb.py", line 69, in trx_fundamental
    results = self.fundamental(m_request.Value, m_request.Type)
  File "/home/maltego/scryingorb/scryingorb/scryingorb.py", line 113, in fundamental
    return self._output(data)
  File "/home/maltego/scryingorb/scryingorb/scryingorb.py", line 246, in _output
    return xform.returnOutput()
  File "build/bdist.linux-x86_64/egg/TRX/TRX.py", line 202, in returnOutput
    r += self.entities[i].returnEntity()
  File "build/bdist.linux-x86_64/egg/TRX/TRX.py", line 135, in returnEntity
    if (str(field['matchingRule']) != "strict"):
TypeError: string indices must be integers, not str