kristoff-it / redis-memolock Goto Github PK

I have found a way to reliably produce an index out-of-range in the example.

go run extended_example.go

Send two GET requests to the same renewable resorce within a few seconds (so the second request has to wait for the promise of the first request):

GET localhost:8080/report/renewable/123

(wait 2 seconds)

GET localhost:8080/report/renewable/123

Then one of the requests fails with:

panic: runtime error: index out of range [1] with length 1

goroutine 35 [running]:
github.com/kristoff-it/redis-memolock/go/memolock.(*RedisMemoLock).dispatch(0xc00028c0c0)
        /Users/oscarvanleusen/go/src/github.com/redis-memolock/go/memolock/RedisMemoLock.go:88 +0x4b9
created by github.com/kristoff-it/redis-memolock/go/memolock.NewRedisMemoLock
        /Users/oscarvanleusen/go/src/github.com/redis-memolock/go/memolock/RedisMemoLock.go:125 +0x20a
exit status 2

The same problem can also be reproduced with the /ext/stemmer and /report/oh-no/ routes. I can't reproduce it with the /query/simple route though.

If I were to guess, this only affects GetResourceRenewable and GetResourceExternal, but not GetResource.

Checking in to see if that's still coming soon. Thanks!

In the examples when the NewRedisMemoLock is initialised a 5-15 second lockTimeout is provided.

This is what's passed to SetNX when acquiring the lock.

However, when I open a terminal into my redis instance and do KEYS * to list the locks and then TTL ${resourceTag}/lock:${resID} it returns this:

127.0.0.1:6379> TTL report/lock:123
(integer) 19999999845

When I run it a few seconds later:

127.0.0.1:6379> TTL report/lock:123
(integer) 19999999835

Which seems to suggest the actual TTL applied onto the lock is 2 billion seconds.

This presents an issue running the examples, because nowhere in the RedisMemoLock actually explicitly frees the lock, once the examples have been called once we can never re-aquire the lock.

Do you have any idea why redis is not respecting the lockTimeout provided by us?

Redis Version

Running redis via docker with default settings.

Redis version=7.0.10, bits=64, commit=00000000, modified=0, pid=1, just started
2023-07-23 01:21:40 1:C 23 Jul 2023 00:21:40.091 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf