kristofa / bookmarker_for_pinboard Goto Github PK

Each time when I create a bookmark, I get the following error:
'When retrieving previously saved bookmark: Got an error when invoking request to api.pinboard.in: The request timed out.'
This is shown before saving a bookmark. When I do try to save, the bookmark is actually being saved in most cases. However the UI doesn't provide any confirmation of that.

It would be really useful to have a default setting for the "Read Later" checkbox so that every bookmark can go into the unread list to be processed later.

The extension popover in Safari should default to having text field focus in either the Title or Tags field instead of the URL field. Users are far more likely to want to edit the title or add tags before saving a bookmark to Pinboard than they are to change the URL. Considering they are bookmarking the URL, chances are that field will almost never be changed, though there are circumstances when it might be.

Suggested by @apas :

In the application main screen it would be useful to have a link that opens a new browser window with the web page that displays your API token (https://pinboard.in/settings/password) when logged into pinboard.

This will make it easier to figure out for users where they can find their API token.

Often I want to edit an entry in my Pinboard.
I do this by re-adding an existing bookmark and editing the existing info.

(examples using Shiori)

http://www.koitsu.com/DB/SearchResults.asp

This is the screen I get when I add for the first time:

I then add any information and press Done.

To edit I do a second add.

I see this information:

I then edit the information and press Done.

This is not currently possible in bookmarker, it gives you a bare "first time" window every time.

One more thing

It would also be good to get a timestamp on when the page was first added to Pinboard. So I could see when it was first added. (An older Safari Extension Pinbar did this as it just launched the pinboard website)

When the pop-up is opened we request pinboard if the given URL is already bookmarked before. If this request times out we blank all the URL details (URL, title, description) which makes saving the URL impossible.

If the full pinboard API is unavailable this isn't necessary an issue as we also wouldn't be able to save a new bookmark. However in case only the request for retrieving an existing URL times out we should not clear the properties so we are still able to add the bookmark although this might mean we override the previously saved bookmark.

This is an example of how the pop-up looks like in this case:

I receive both of these issues when I try to add a bookmark.

The following one appears just after the popover is clicked:
When retrieving previously saved bookmark: Got an error when invoking request to api.pinboard.in: The request timed out.

Then, the following error appears when I click Add Bookmark:
When adding or updating bookmark: Got an error when invoking request to api.pinboard.in: The request timed out.

Many thanks for the updated deployment!

I have installed successfully via the App Store on macOS 10.13.6, Safari 12.1 (13607.1.40.1.5).

"bookmarker for pinboard" launches as expected, and lets me set the API token (very nice, clean work, BTW).

But the "Open in Safari Extensions Preferences…" button does nothing when clicked.

And the extension does not appear in Safari > Preferences > Extensions.

I have tried a reboot just in case. No change.

Please advise any troubleshooting steps I can take, or bug reporting information I can provide.

I am very excited for this Extension to come to Safari 12, and would love to help in any way I can.

Currently if I go to save a page and begin typing in tags, I will get the autocomplete options; however I am unable to use the keyboard to select the one I want, nor am I able to use the pointer to click on the desired one.

If using the arrow keys to select the tag:

• Able to press down once to select a tag, but a second time causes the second tag to be selected and the autocomplete options to close. Currently only able to select up to the second autocomplete tag selection.

If using the mouse to select the tag:

• It just causes the window to close.

MacOS 11.1 on a 2020 M1 Macbook.

The idea to support Wayback machine came up in the Pinboard user group:

It would be nice to use the Wayback Machine API to automatically detect whether the Internet Archive has a copy of the URL and, if so, provide a link to it.

Details are available here: https://archive.org/help/wayback_api.php

Additionally, when saving a bookmark, Pinboard could make a request to https://web.archive.org/save/{full URL of bookmark} to save the page in the Wayback Machine for future use.

First of all, thank you for making this!

If possible, please consider adding the ability to use the currently selected text from the page being bookmarked as the description of the bookmark.

• It may be useful to some to be able to mark bookmarks as private or not when adding.
• A default setting for the checkbox should also be implemented so that, for example, private can be set as default to prevent the accidental public bookmarking of private information.
• pinboard.in account locking when enabled will override to make all bookmarks private this is pinboards current functionality.

I'm stuck on 10.13.6 for the time being. Is 10.14 a requirement? Mac App Store claims so. Thx

I can routinely cause a crash by saving a bookmark. (The bookmark does get successfully saved.) This is an a 2015 13" Retina MBP running Mojave (10.14.5) in clamshell mode.

Console log reveals:
default 00:16:07.849379 -0400 bookmarker for pinboard Extension *** Assertion failure in -[bookmarker_for_pinboard_Extension.SafariExtensionViewController dismissViewController:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1671.50.111/Controllers/NSViewController.m:858

error 00:16:07.850187 -0400 bookmarker for pinboard Extension An uncaught exception was raised

Attaching crashlog.

bookmarker for pinboard Extension_2019-06-12-001609_Mycroft.crash.txt

On saving a page, the extension encountered an error.

However, the error message was truncated, and so I couldn't read the reason.

This was requested by @apas.

When adding a link was successful there is no need to keep the popover window open. It also requires an additional action to close it. So it is more efficient to automatically close it and only leave it open to show the error message in case adding the link failed.

For faster bookmarking using the extension, set the Return key to trigger the Add Bookmark button in the popover window. In combination with Issue #3 and with the text input focus now in the Tags field (issue #9), this would allow a complete bookmarking workflow without having to take one's fingers off the keyboard.

Suggested by @apas :

Support a keyboard shortcut for opening the popover window. This will make it faster to open the window instead of having to use a mouse or touchpad to navigate to the toolbar button.

When typing the description and tags of a new bookmark it would be useful, if possible, to autocomplete a tag based on the users' existing tags.

For instance, a user would type pro and programming and productivity would appear either as a dropdown or inside the text field. The user could press TAB to autocomplete the rest of the word or navigate with the arrow keys and select the tag.

Blue on white is not good when using dark mode.

(colours should be specified as named system colours to work in both light/dark modes)

Extending #3: adding the option to customize the keyboard shortcut which opens the popover menu. Low priority.

I followed the instructions from the wiki and when I clicked the Update API Token button, I got a message that says: "Invalid API token format. Expecting username:TOKEN"

I copied the token exactly as it appeared at https://pinboard.in/settings/password

I figured out how to fix it when I noticed that "TOKEN" was all caps in the error message. When I changed the token provided to me by Pinboard—which was a mix of lowercase letters and numbers—to uppercase, it worked.

The application should accept the API token in the format provided by Pinboard.

Feature Request:
Would it be possible to support Pinboard's Tab Sets feature? Sending all tabs from all windows to save at once is really useful! Thanks!

I know I'm about to ask for something quite hard to do buuuut... I'm still sad about the "death" of CloudMark (and so many cool extensions the same dev made). Any chance to have an extended version which displays / offers search for our bookmarks? Damn I wish I could code. ;) Anyway, awesome work here, thanks for this tool!

Lately, when I try to bookmark a URL the first try always fails with the following error: "Got an error when invoking request to api.pinboard.in: The request timed out."

�If I try to bookmark the URL again it works.

Since moving to an M1 MacBook (Safari 15.6.1). I find that if I select a tag from the dropdown, the bookmarker invariably closes without saving the link to Pinboard. The link is correctly saved if I type in the tag.

When pressing <enter> in the Description text field the URL gets submitted to Pinboard. This prevents you from adding multi-line descriptions unless you copy/paste the description from somewhere else.

Submitting the URL using <enter> makes it easy to submit a URL using the keyboard only and prevents the need to move the mouse / trackpad cursor but I think we should make an exception for the Description text field.

Even when the Default "Private" setting is set in the app, the checkbox in the popover window in Safari isn't checked.

I've tried various combinations of setting/unsetting the setting in the app and deactivating/reactivating the extension in Safari to see if that made it work, to no avail.

(Also, the setting in the app should really be a checkbox rather than a dropdown.)

The fix for Issue #10 allows us to trigger saving a bookmark using the keyboard but restricts it to the Description and Tags field. It should apply to the Title and URL fields as well. If a user edits those fields they then have to tab to Description or Tags to hit Return and save and they shouldn't have to do that.