kpn / django-etcd-settings Goto Github PK

I tried to offload all of my deployment-specific settings in my DJANGO_SETTINGS_MODULE to etcd_settings but I'm not able to do so because the following line causes django.conf.settings to be imported:

from etcd_settings.loader import get_overwrites

In etcd_settings/__init__.py the EtcdSettingsProxy is instantiated the moment my import happens. This in turn tries to get the DJES_* settings. At this moment SECRET_KEY is missing from the settings because it is one of the values I want to fetch through etcd_settings.

So far, my solution has been to set SECRET_KEY to some fake value before importing etcd_settings but I don't think this is the best solution. IMO it would be better to move the instantiation of EtcdSettingsProxy out of the package __init_.py.

All values in Django ETCD settings are supposed to be encoded in JSON format.

If JSON decoding is impossible, then EtcdConfigInvalidValueError is raised in https://github.com/kpn-digital/django-etcd-settings/blob/master/etcd_settings/manager.py#L95 and breaks the application.

This error should be caught and logged instead of raising an exception.

Documentation now mentions X-Dynamic-Settings while it should be X-Dynamic-Setting.
The usage of this feature should also be documented a little more (like the fact that you can provide one or more keys and how to configure it in ETCD).