koriym / koriym.attributes Goto Github PK

Hi Akihito,

this package is exactly what I was looking for. Doctrine annotation reader that would be able to read attributes and create objects from them 👍

Amazing work, thanks!

@koriym Hi, I came to a bug when only annotations or attributes are used. The DualReader can handle only one of them, depending on PHP version.

This caused missing annotations on PHP 8. I think more reliable solution would be class like this one - that reads both annotations and attributes on PHP 8, if available. That's what I expected from DualReader class and that's where it failed my expectations. But maybe there is a better way to do it.

From contributte/apitte#165 (review)

Hi,

Currently on this package, doctrine annotation dependency is on version 1.x, is there any plan to upgrade to 2.x? (Php 8.2 support)

Thanks

With Dual Reader, two "annotations" will be read in the following cases.

#[FakeCacheable]
/**
 * @FakeCacheable
 */
class FakeDual

Shouldn't only one annotation be read?
(This can be done using array_unique)

It is mainly intended for library code, so all users of the doctrine/annotation reader, attribute reader, and the dual reader will get the same results.

Upgrading to 1.0.1 has caused some tests to fail .

@TomasVotruba Thoughts?