kohlstechnology / blackbox-helloworld-responder Goto Github PK

The binaries attached to the v0.1.9 release appear to have been built with Go 1.15.15. I was expecting the released binaries to be built with Go 1.17.3.

What happens?

This project does not provide officially released binaries for Darwin ARM64(i.e. Apple Silicon).

What were you expecting to happen?

Darwin ARM64 binaries are provided on the releases page.

Steps to reproduce:

Open the releases page and notice that Darwin ARM64 binaries are provided.

Any errors, stacktrace, logs?

N/A

Environment:

N/A

Additional comments:

N/A

What happens?

The webserver and TCP server do not terminate gracefully. There is no signal handler to do a graceful shutdown.

What were you expecting to happen?

When the application receives a SIGTERM signal is does a graceful shutdown.

Steps to reproduce:

Start the application then send it a SIGTERM signal using the kill(1) command.

Any errors, stacktrace, logs?

N/A

Environment:

• Runtime version(Java, Go, Python, etc): N/A
• Desktop OS/version: N/A

Additional comments:

None.

(While submitting an issue briefly describe the problem you are facing or a new feature you would want to see added)

What happens?

The incorrect version number is printed in the logs when running the container image. The below log line was captured from the v0.1.5 container image.

2022/04/18 21:57:35 blackbox-helloworld-responder, version v0.1.13 (branch: HEAD, revision: 2ed20806ee9b01fe8c16a157b2c4d50e5f107188), build date: 20220418-18:49:21, go version: go1.18.1

What were you expecting to happen?

The correct version number is printed in the logs

Steps to reproduce:

• Download container image
• Run it
• Look at the version number printer by the first log line

Any errors, stacktrace, logs?

See above.

Additional comments:

N/A

What happens?

When the deploy pipeline runs, there are deprecation warnings

What were you expecting to happen?

No deprecation warnings in the job output

Steps to reproduce:

• Run the test pipeline

Any errors, stacktrace, logs?

Warning: Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache']
Post job cleanup.
Omitting ~/.cache/go-build from cache directories
Omitting ~/go/pkg from cache directories
Cache hit occurred on the primary key golangci-lint.cache-[2](https://github.com/KohlsTechnology/blackbox-helloworld-responder/actions/runs/3988566450/jobs/6839895637#step:18:2)768-f522a5d0511776ecd5165258[4](https://github.com/KohlsTechnology/blackbox-helloworld-responder/actions/runs/3988566450/jobs/6839895637#step:18:4)d2e7d7808a492[5](https://github.com/KohlsTechnology/blackbox-helloworld-responder/actions/runs/3988566450/jobs/6839895637#step:18:5)b, not saving cache.

Ref: https://github.com/KohlsTechnology/blackbox-helloworld-responder/actions/runs/3988566450/jobs/6839895637#step:18:1

Let's try to use GitHub Actions instead of Travis CI and see if we like it better.

What happens?

When a release is created, only the most recent commit is shown in the release notes

What were you expecting to happen?

Any commits that are included in that release should be noted in the release notes

Steps to reproduce:

• Create a release
• Look at the releases for the project

What happens?

I read through README.md and I could not find the container registry location for the released container images.

What were you expecting to happen?

The container registry location for this project should be documented.

Steps to reproduce:

Read this document: https://github.com/KohlsTechnology/blackbox-helloworld-responder/blob/master/README.md

Any errors, stacktrace, logs?

No

Environment:

N/A

Additional comments:

N/A

Rename project to helloworld-responder. The quay.io registry for this project will also need to be renamed.

https://github.com/snyk/actions

What happens?

When new versions of golangci/golangci-lint and goreleaser/goreleaser are released, dependabot does not pick up those versions.

What were you expecting to happen?

These versions to auto-update

Steps to reproduce:

N/A

Any errors, stacktrace, logs?

N/A