kodie / reather

A React Weather App Exercise

Reather

A React Weather App Exercise

Installation

$ git clone https://github.com/kodie/reather.git
$ cd reather
$ npm install

Development

$ npm start

The app will start in development mode available at http://localhost:3000 and will automatically refresh if you make any edits.

Test

$ npm test

All API calls are mocked so that tests can be ran offline.

Build

$ npm run build

An optimized production version of the app will be built in the /build folder. react-snapshot is used to pre-render the app.

Deployment

The app is automatically tested and then built and pushed to the gh-pages branch (which is served via GitHub Pages and available at https://kodie.github.io/reather) via Travis CI whenever a commit is pushed to master.

Optionally you can build and deploy manually by running:

$ npm run deploy

License

MIT. See the LICENSE file for more info.

reather's Issues

More tests!

Currently it only runs 4 tests, I'd like to add some more. For example a test to check if getWeather() is properly distinguishing between a city name, zip code, or coordinates.

Favicon needs to be replaced

Location names are sometimes different between geonames.org and openweathermap.org APIs

For example, if you search for and select "Newton, Florida" from the autocomplete drop-down and press "Go!", the location name is "Tallahassee" in the results.

Also if I'm at my house in Des Moines, Iowa, and allow the app to get my coordinates and press "Go!", the location name is "Pleasant Hill" in the results which happens pretty often with other location based apps as well.

I'm guessing this has to do with the locations being close to each other.

Clicking on header results in 404 error

This only happens if the app is running in a sub-directory (which it is at https://kodie.github.io/reather).

Possibly add an option to allow user to switch country and units

Currently country and units are hard-coded via src/settings.json

Setting location via URL path doesn't work on GitHub Pages

I commented out all the code that handled this (605dde3) for now.