kodi-pvr / pvr.demo Goto Github PK

I like to make a feature suggestion, and that is the add a recording functionality into this PVR client addon. Both for demo purposes but also for real like purpose as the PVR demo client addon is also used as a source for forking when creating new PVR client addons for Kodi.

The ability to "record to disk" from a user experince. In function be able act a DVR (Digital Video Recorder), to save individual video streams to local disk directory/folder. Preferably even save as video files in MPEG-TS (.TS) format just like real DVRs.

This ability to record can also add more features which have dependency on recording, like the ability to "Pause" and "rewind" Live TV if could add the possibility to continusly record to a series of temporary files in a look, again just like a read DVR.

All such a function is normally located and dependent in the PVR backend instead of the PVR client addon, but this PVR client addon is somewhat unique in that it connects to the content streams directly, streaming directly from, so it does not go through a third-party PVR backend which can bring such recording functionality. And in addition it would be very nice to have the ability for the video files to be saved locally directlly on an Android device instead of on the PVR backend.

Lot's of duplicated code here, that should be consolidated.

Look at this diff for example, and you willl see what I mean: https://github.com/kodi-pvr/pvr.demo/pull/58/files#diff-f7801a13a8ddf8eed26107526bfd0b9e

According to https://github.com/kodi-pvr/pvr.demo/blob/master/pvr.demo/addon.xml.in, the current version is 3.0.1. Can you please tag this release?

Releases make things a lot easier for distributions (in my case, Gentoo) to package the add-on.

Thanks!

Hi; I use Fedora Linux 22; I try compile all pvr addons for Kodi 15; but this new Implements, breaks the build; all pvr-addons present the same problem; on may doesn't existed this issue, here the log:

~/build/BUILD/kodi-pvr-addons/pvr.demo/build ~/build/BUILD/kodi-pvr-addons

• file=addons.txt
• IFS=
• read -r line
• mkdir -p pvr.demo/build
• pushd /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/build
• cmake .. -DADDONS_TO_BUILD=pvr.demo -DADDONS_SRC_DIR=pvr-addons -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debug
  -- The C compiler identification is GNU 5.1.1
  -- The CXX compiler identification is GNU 5.1.1
  -- Check for working C compiler: /usr/lib64/ccache/cc
  -- Check for working C compiler: /usr/lib64/ccache/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/lib64/ccache/c++
  -- Check for working CXX compiler: /usr/lib64/ccache/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Checking to see if CXX compiler accepts flag -flto
  -- Checking to see if CXX compiler accepts flag -flto - yes
  -- PVRDEMO_VERSION=1.11.3
  -- Configuring done
  -- Generating done
  CMake Warning:
  Manually-specified variables were not used by the project:
  ADDONS_SRC_DIR
  ADDONS_TO_BUILD
  -- Build files have been written to: /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/build
• make
  Scanning dependencies of target pvr.demo
  [ 33%] Building CXX object CMakeFiles/pvr.demo.dir/src/client.cpp.o
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:312:25: error: 'PVR_TIMER_TYPE' was not declared in this scope
  PVR_ERROR GetTimerTypes(PVR_TIMER_TYPE types[], int size)
  ^
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:312:49: error: expected primary-expression before 'int'
  PVR_ERROR GetTimerTypes(PVR_TIMER_TYPE types[], int *size)
  ^
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:312:58: error: expression list treated as compound expression in initializer [-fpermissive]
  PVR_ERROR GetTimerTypes(PVR_TIMER_TYPE types[], int *size)
  ^
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:313:1: error: expected ',' or ';' before '{' token
  {
  ^
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp: In function 'PVR_ERROR DeleteTimer(const PVR_TIMER&, bool, bool)':
  /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:363:71: error: conflicting declaration of C function 'PVR_ERROR DeleteTimer(const PVR_TIMER&, bool, bool)'
  PVR_ERROR DeleteTimer(const PVR_TIMER &timer, bool bForceDelete, bool /bDeleteScheduled/) { return PVR_ERROR_NOT_IMPLEMENTED; }
  ^
  In file included from /builddir/build/BUILD/kodi-pvr-addons/pvr.demo/src/client.cpp:23:0:
  /usr/include/kodi/xbmc_pvr_dll.h:370:13: note: previous declaration 'PVR_ERROR DeleteTimer(const PVR_TIMER&, bool)'
  PVR_ERROR DeleteTimer(const PVR_TIMER& timer, bool bForceDelete);
  ^
  CMakeFiles/pvr.demo.dir/build.make:62: recipe for target 'CMakeFiles/pvr.demo.dir/src/client.cpp.o' failed
  CMakeFiles/Makefile2:99: recipe for target 'CMakeFiles/pvr.demo.dir/all' failed
  Makefile:149: recipe for target 'all' failed
  Errores de construcción RPM:
  make[2]: ** [CMakeFiles/pvr.demo.dir/src/client.cpp.o] Error 1
  make[1]: *** [CMakeFiles/pvr.demo.dir/all] Error 2
  make: *** [all] Error 2

I've implemented strEpisodeName, iSeriesNumber, iEpisodeNumber for PVR_Recordings as per #58

In conjunction with the skin changes to estuary (xbmc/xbmc#13300), there is a display issue when a recording only has an iEpisodeNumber, but im not seeing anything obvious from the addon or skinning side, so not sure if its a kodi problem or not?

The issue can be seen when viewing Recording "Demo TV Recording entry 2" and also deleted recording "Demo TV Recording entry 12" . Deleted recording "Demo TV Recording entry 11" also is wrong, as it doesnt show season number.

From what i can see, they use the exact same include that is working without any issues for the Guide view and the Channel view, so i dont think its a skinning issue as such, as i would expect the problem to be there with any view using the include.

The ints are being set correctly into the PVRDemoRecording object (logging was used to verify this locally), so i dont think its the demo addon either thats mangling the episode/series number.

If you can point me to where kodi receives/handles the iepisode and passes it onto the skin, im happy to go on a hunt, ive just no idea how the skin receives the data after the entries have been transferred to kodi.

Recordings

This is correct

This should show E3 Demo TV Recording 2 Episode Name

This is correct

Deleted Recordings

This one should show S1E2 Demo TV Recording entry 11 Episode Name

This should show E3 Demo TV Recording entry 12 Episode Name

Episode title only is correct