kobzol / davis Goto Github PK

.data labels cannot be used in [dereference].

Labels in .data section (except the first label) are treated as .text labels.

section .data
string_origin:
db 'ahojx', 0
string_result:
db ' ', 0
string_len:
dd 0x5

section .text
MOV ECX, [string_len]
load:
MOV EDX, string_origin
MOV BL, BYTE [EDX + ECX * 1 - 1]
SUB BL, BYTE 32
MOV EDX, string_result
MOV [EDX + ECX * 1 - 1], EBX

DEC ECX
CMP ECX, 0
JE end
JMP load

end:
HLT

MOV [EDX + ECX * 1 - 1], EBX is not working correctly

BL → BYTE EBX etc.

Logical Operators(e.g Xor and And) not implemented

Could you make the UI closer to the one that inspired you https://schweigi.github.io/assembler-simulator/

When a mem location or register changes then show a different colour.
Use horizontal spae more effectively - eg 16 wide mem and not 8.

Take alook back at .. https://schweigi.github.io/assembler-simulator/

Thanks

By the spec it's defined as DEST ← (DEST – (SRC + CF));

But I think it's implemented as DEST ← (DEST – SRC + CF);

Reproducible with this snippet.

    MOV EAX, 10
    MOV EBX, -1 ; 
    ADD EBX, 1 ; CF = 1
    SBB EAX, 0 ; EAX = (EAX - (0 + CF)) = EAX - 1 = 9
    ; EAX should be 9, it is 11