Coder Social home page Coder Social logo

file-server's People

Contributors

dead-horse avatar jonathanong avatar zedgu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

file-server's Issues

about multi-directory

Is there any plan to support the multi-directory with custom alias?
Such as:

require('koa-file-server')({
  path: {
    assets: './assets',
    avatars: '/mnt/nas/users/uploads/avatars'
})

Cache safety

On line 182 if the file from the cache has been removed while the server is running, the file-server will bug out if it thinks the file exists. Perhaps we should check that the file exists if we detect it in the cache object so it can regenerate the file?

For example: if (cache[path] && fs.existsSync(path + '.gz')) return cache[path] (although nodejs says we shouldn't use fs.exists)

Vary-header needs to be set

Since we potentially send the file using either Identity or gzip-encoding, we need to set the Vary-response header to Accept-Encoding. Otherwise, we might end up serving incorrect resources to clients, especially when public proxies are involved

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.