Coder Social home page Coder Social logo

diffutil_sliverlist's Introduction

Hi there ๐Ÿ‘‹

diffutil_sliverlist's People

Contributors

knaeckekami avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

b3nni97 dimeskigj

diffutil_sliverlist's Issues

Index in builder function

I'd like to have access to an item's index in the builder function, in addition to the existing BuildContext and item T. If needed, I could offer this change myself in a PR. Let me know!

Implementation of move is missing

Hi!

Great work with this package! I have a question regarding the missing move-implementation, is there a reason for this? It seems to be supported in diff_util?

void _onDiffUpdate(diffutil.DiffUpdate update) {
  update.when<void>(
      move: (_, __) =>
          throw UnimplementedError('moves are currently not supported'),
      insert: _onInserted,
      change: _onChanged,
      remove: _onRemoved);
}

Best regards

Handling/copying the lists provided to DiffUtilSliverList

The documentation states:

Don't mutate the list passed into DiffUtilSliverList yourself
...
either copy the list before mutation:
...
Or just copy the list before passing it to DiffUtilSliverList:
DiffUtilSliverList<int>(items: List.from(list), ...),

Is there a reason why this library does not automatically copy the list for users so this isn't needed? The list will need to be copied at some point for DiffUtil to work correctly anyways; I don't see why DiffUtilSliverList can't copy the list itself and take some work away from library users. Plus, this addition won't be a breaking change.

If I am missing something here/not understanding this correctly, please do let me know. But, if not, I'd be happy to open a PR for this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.