kleros / linguo-contracts

Linguo Smart Contracts

Linguo Contracts

Smart contracts for Linguo.

Deployed Addresses

• Kovan: deployments
• Mainnet: deployments
• Goerli: deployments
• Sokol: deployments
• xDAI: deployments

Contributing

Install Dependencies

yarn install

Run Tests

yarn test

Compile the Contracts

yarn build

Run Linter on Files

yarn lint

Fix Linter Issues on Files

yarn fix

linguo-contracts's Issues

Review by @unknownunknown1

https://docs.google.com/document/d/1cTDynzHra-rDfn20EGKUF-QAwO9lthQBBsv4aWbThV8/edit

Review Linguo.sol

Review by @nix1g

Linguo.sol Review @ 62e7de0

No major issues, working as intended.
Some gas optimization can be made, though it is not worth adding them at this point in development.

Suggestions

1. maxPrice is underused and can be functionally replaced by requesterDeposit.
2. Some require() can be done earlier to clarify code: L270, L361-L362, L418-L419, L544-L545.
3. L548-L549 == true is unnecessary.

Questions

1. Why is the reviewTimeout set globally? I'm not sure all translation works require the same amount of time to review.

Review by @fnanni-0

https://docs.google.com/document/d/16c9JjKP3aqg_dzQ2pgN99Us44KXMe2SRX_f-jZEgp7w/edit