kkritos / rapster Goto Github PK

View Code? Open in Web Editor NEW

11.0 11.0 3.0 7.57 MB

Rapid population synthesis code for binary black hole mergers in dynamical environments.

License: GNU General Public License v3.0

Python 100.00%

rapster's People

Contributors

Stargazers

Watchers

Forkers

steve-hawk kcroker alorikakar2014

rapster's Issues

star-star binaries created by triple-star interactions

the variable aStarStar_min seems not to have been defined here, so the condition of the if will not be satisfied all the time.

Rapster/rapster.py

Lines 868 to 889 in 6b85409

    
           if kTripleStar>0 and aStarStar_min < aStarStar_har: # new hard binary stars form; 
        
           # also make sure the hardness sma is above the minimum allowed binary star separation 
        
               for i in range(0,kTripleStar): 
        
                   # sample hardness ratio: 
        
                   etaValue = hardness_sampler(np.random.rand(), mAvg, mAvg, mAvg, mAvg, 0.4, etamin=5) 
        
                   # new sma: 
        
                   smaNEW = G_Newt*mAvg/etaValue/veloDisp(mAvg,1,mAvg,Mcl,rh)**2 
        
                   # make sure stars in binary are not very close together; if so, draw hardness ratio again: 
        
                   while smaNEW < aStarStar_min: 
        
                       # sample hardness ratio: 
        
                       etaValue = hardness_sampler(np.random.rand(), mAvg, mAvg, mAvg, mAvg, 0.4, etamin=5) 
        
                       # new sma: 
        
                       smaNEW = G_Newt*mAvg/etaValue/veloDisp(mAvg,1,mAvg,Mcl,rh)**2 
        
                   # append new sma: 
        
                   aStarStar = np.append(aStarStar,smaNEW)

t_form of BBHs from ZLK merger (when triple systems exist) is always zero

Rapster/rapster.py

Line 2300 in f21140d

i = i - 1

the update of running iteration index needs to be moved after

Rapster/rapster.py

Lines 2319 to 2322 in f21140d

    
           mergers = np.append(mergers,[[4,aIn,np.sqrt(1-epsilonMIN),m0,m1,s0,s1,g0,g1,\ 
        
               triples[i][15],t+tLocal+tauZLKmerger,triples[i][16],redd(t_lbb(zClForm)-t-tLocal-tauZLKmerger),\ 
        
                   0,0,np.min([m0,m1])/np.max([m0,m1]),chiEff,theta0,theta1,dPhi,\ 
        
                                        mRem,sRem,gRem,vGW,jBH_0,jBH_1]],axis=0)

when use triples[i][15]

sample size (size=2) sometimes is larger than the size of mBH

when entering if k3bBH > 0:, N_BH_sin has not been well updated by a potential N_BH_sin = mBH.size before the if condition.

Rapster/rapster.py

Line 1095 in f21140d

masses = np.random.choice(mBH,size=2,replace=False,p=p_)

will report an error when mBH is smaller than 2, which usually happens at the end of a simulation.

kkritos / rapster Goto Github PK

rapster's People

Contributors

Stargazers

Watchers

Forkers

rapster's Issues

star-star binaries created by triple-star interactions

t_form of BBHs from ZLK merger (when triple systems exist) is always zero

sample size (size=2) sometimes is larger than the size of mBH

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if kTripleStar>0 and aStarStar_min < aStarStar_har: # new hard binary stars form;
	# also make sure the hardness sma is above the minimum allowed binary star separation

	for i in range(0,kTripleStar):

	# sample hardness ratio:
	etaValue = hardness_sampler(np.random.rand(), mAvg, mAvg, mAvg, mAvg, 0.4, etamin=5)

	# new sma:
	smaNEW = G_NewtmAvg/etaValue/veloDisp(mAvg,1,mAvg,Mcl,rh)*2

	# make sure stars in binary are not very close together; if so, draw hardness ratio again:
	while smaNEW < aStarStar_min:

	# sample hardness ratio:
	etaValue = hardness_sampler(np.random.rand(), mAvg, mAvg, mAvg, mAvg, 0.4, etamin=5)

	# new sma:
	smaNEW = G_NewtmAvg/etaValue/veloDisp(mAvg,1,mAvg,Mcl,rh)*2

	# append new sma:
	aStarStar = np.append(aStarStar,smaNEW)

	mergers = np.append(mergers,[[4,aIn,np.sqrt(1-epsilonMIN),m0,m1,s0,s1,g0,g1,\
	triples[i][15],t+tLocal+tauZLKmerger,triples[i][16],redd(t_lbb(zClForm)-t-tLocal-tauZLKmerger),\
	0,0,np.min([m0,m1])/np.max([m0,m1]),chiEff,theta0,theta1,dPhi,\
	mRem,sRem,gRem,vGW,jBH_0,jBH_1]],axis=0)