kjendrzyca / klesk Goto Github PK

It should be possible to add timeboxed seasons to ladders.

repro steps:
/klesk newlader normal
/klesk showstats notmal
result:

• leaving ladder
• adding result
• new ladder

see: 3408176

We don't track those in this repo but having those example files would be useful.

Add parameter to npm start to disable writing to standard output

It is related to the problem that command bus and command handlers factory is not fully async as it should be in node.

Example:
/klesk addresult existingladdername +existingwinner nonexistentplayer2

Currently if second player does not exist, nothing happens. Imo error message should be sent to the user.

Ladder should pick random map at the beginning of each seson.

What do you think about it? Is error logging enough? Or do we need something more?

• when result is added
• when someone joins ladder

When sending request without user_name field, Klesk creates matches with one player.

Command: curl -d "text=joinladder test" http://localhost:1666
Result: "Added: undedfined"
ladder.json: {"player2":"patryk","winner":""},{"player2":"tarnas14","winner":""}

make ranking display something like

[ladder `normal` matches played 3/5] 1. prezes 3/0 2. patryk 2/1 3. tarnas14 0/3 etc....

instead of showing all matches

When you add result with command like this:
/klesk addresult +klesk anarki 23:18

and in the ladder.json players are placed in a different order:

{ 
    matches: [ 
        {
            player1: 'anarki', player2: 'klesk' 
        }
    ]
}

then you get stats like this:
[ anarki vs +klesk (23:18) on furious heights]
but should be
[ anarki vs +klesk (18:23) on furious heights]

The best solution would be to fix how the score is saved, not how it is displayed.