kjartane / seng468-goblin-trade

SENG468-Goblin-Trade

Setup guide

• install dep if outdated
  • make install
• run app
  • make web
• clean app
  • make clean

Issue with Make

Windows Setup (after npm install make)

1. Run PowerShell as Admin
2. Set-ExecutionPolicy RemoteSigned
3. Y

seng468-goblin-trade's Issues

Users see all recently placed stock transactions

Found an issue to address:

All users add to the same stock transactions list when placing an order. Additionally, all users can see this unified stock transaction list when viewing their stock transaction history.

Steps to reproduce:

1. Re-build and run all portions of the app. make clean, then make install, then make in the main directory.
2. Log in as any user
3. Navigate to Place Order and place any stock order.
4. Navigate to the user's stock transaction history. "Stock Details">"Transaction History". Observe the recently placed transaction in history table.
   
5. Log out and sign in as a different user.
6. Navigate to the different user's stock transaction history. "Stock Details">"Transaction History". Observe that this different user can see the same transaction placed by the previous user.

The process is repeatable. Orders placed by any user account will be visible by all accounts.

Possible fix:

Currently the backend only returns a list of all stock transactions placed by all users. This logic can be seen in the function getStockTransactions() used in order.routes.ts and order.controller.ts. We need to implement a filter in this logic to only find stock transactions placed by the currently signed in user. The desired functionality can be seen in stock.routes.ts and stock.controller.ts for the getStockPortfolio() function. Using the user's auth key in a similar way we can find stock transactions per user.

Important Notes

If the database already has a separate stock transaction history table for each user, then a fix for this is pretty straightforward as outlined above. Otherwise, if the backend is just storing all stock transactions into one table in the database, then logic must be implemented to create a table for each user, or add a user_name to each entry.

A separate transaction table for each user will probably be faster? If there was only one table then the backend would have to comb through the entire table and pick out only the currently logged in user's transactions, which would be wasteful when the table gets large. Any additional thoughts on the matter is appreciated.

Originally posted by @stephenneale in #22 (comment)