kivy-garden / animationbuilder Goto Github PK

This is not an actual issue, but more like suggestion. Sorry I don't know where should I write this.

Reason 1: freestyle expression is always substitutable with another method

For example:

test:
  freestyle: "(anim1 + anim2) & (sleep(2) + anim3)"

is equivalent to

test:
  P:
    - S: [anim1, anim2]
    - S: [{d: 2}, anim3]

which is equivalent to

test:
  P:
    - S:
      - anim1
      - anim2
    - S:
      - d: 2
      - anim3

I don't know which one is better.

Reason 2: reducing code

BinOp(), Add(), BitAnd(), Expr(), Name(), Call(), Call_sleep(), compile_node()

These methods are only used by "freestyle expression"

I myself couldn't decide how should do about this.

@KeyWeeUsr

I think this flower is useless because asyncio and trio can handle animations more flexibly compared to Sequence and Parallel, which are what the flower depends on.

So if you agree with me, I want you to delete or archive the repository.

EDIT:
I just realized that I can archive it. So if no one against me, I'm going to do that.

I recently switched the base flower and some actual flowers to use github actions. I'm opening an issue here to suggest this flower also update if you can.

You can see the changes I made here: https://github.com/kivy-garden/graph/commits/master.

With these changes, the action will:

• Run tests on win/linux and lint (PEP8) the code for each push/PR.
• Auto generate wheels and source dist for each push/PR as artifacts.
• On a tag it'll also create a draft release on github with all the wheels. This will make it easier to manually upload to pypi.
• On each push it'll generate the docs and upload to gh-pages.

The following changes were also made in this PR and previously:

• setup.py uses find_namespace_packages. extras_require was updated.
• We switched to a _version.py file because otherwise there are import issues if kivy is not already pre-installed (kivy-garden/flower#1).
• For the docs, we switched to the sphinx_rtd_theme theme in conf.py.
• I moved the tests directory under kivy_garden/flower so it is installed when the flower is installed.
• Removed .travis.yml and added github workflow.

Mainly because

Accessing through locals and globals is annoying

Instead of writing like this:

anims = AnimationBuilder.load_string('...')
anims.globals['some_attr'] = 'some_value' 
anims.locals['some_attr2'] = 'some_value2' 

wanna write like this:

anims = AnimationBuilder.load_string('...')
anims['some_attr'] = 'some_value' 
anims['some_attr2'] = 'some_value2' 

I probabely should hide locals and globals from users.

The place of repeat attribute, I feel it's weird

shake_anim:
  repeat: True
  sequence:
    - right: 30
      d: .5
    - left: 30
      d: .5

Since repeat is a attribute of kivy.animation.Sequence I wanna write like this:

shake_anim:
  sequence:
    repeat: True
    - right: 30
      d: .5
    - left: 30
      d: .5

But this produce syntax error.

Prefixes are annoying(already fixed)

Instead of writing like this:

change_color:
  color: "eval: get_random_color()"
  d: "eval: random() + additional_time"

wanna write like this:

change_color:
  color: "get_random_color()"
  d: "random() + additional_time"