kitodo / kitodo-demo Goto Github PK

Can you upload kitodo: kitodo-demo to Packagist for automatic installation with composer?

The work's title in the page view's header as well as the metadata tab is shown twice:

• The image manipulation options are missing their labels, so you can't tell which setting is controlled by a specific slider. In addition the box is transparent, which makes it hard to read:
  
• Of all the functions at the top some are missing a label as well: While the zoom and rotation buttons may be recognizable without a label, the cropping feature and the magnifier aren't. For the sake of consistency and accessibility, all functions should have a label.

In Collection List

In your demo installation, I see the following html code for a facet subtitle in a collection list

<ul>
  <li class="tx-dlf-search-no tx-dlf-search-ifsub">
    <span class="facet-sub-title">Erscheinungsort</span>
    <div class="dropdown-menu">
      <ul>

In my installation i get only

<ul>
  <li class="tx-dlf-search-no tx-dlf-search-ifsub">
    Erscheinungsort
    <div class="dropdown-menu">
      <ul>

The only way to get your <span ... is with a change in typo3conf/ext/dlf/Classes/Plugin/Search.php

I add in Line 557 this span

// Process results.
foreach ($facet as $field => $values) {
    $entryArray = [];
    $entryArray['title'] = '<span class="facet-sub-title">' . htmlspecialchars($this->conf['facets'][$field]) . '</span>';

@chrizzor: is there another or better way?
Otherwise i will do a PR.

When i open a Multivolume Work in page view i see tree "undefined" in navigation:

<ul class="tx-dlf-navigation">
....
<li class="tx-dlf-navigation-edit">undefined</li>
<li class="tx-dlf-navigation-editRemove" style="padding-left: 4px;">undefined</li>
<li class="tx-dlf-navigation-magnifier" style="padding-left: 4px;">undefined</li>

You can see this in the Demo-Installation
Das Steinkohlenrevier von Lugau-Oelsnitz:
https://presentation-demo.kitodo.org/index.php?id=4&tx_dlf%5Bid%5D=797&tx_dlf%5Bpage%5D=1

For a volume or monograph, the following will be displayed instead

The site title throughout the whole demo installation is typo3 followed by a colon and the page's title. I'd expect this to be less generic, at least replacing typo3 by a more meaningful title like Kitodo Demo.
Maybe even show the work's title as page title in page view.

• When adding an item to the basket, you get redirected to the basket view. But there is no way to get back to the page you came from (other than using the brower's back function, which causes other problems). I'd expect to not get redirected to the basket instantly or at least be able to return to the previous page.
• If you click on an item in the basket, the basket get's duplicated in a separate tab. I'd expect to get redirected to the page view showing the clicked item instead.
• The download function doesn't work. A loading indicator appears for a second, but nothing happens.

Thus the basket feature currently is completely broken as you can't do anything with the items you added to the basket. They are just there, but cannot be downloaded or viewed again. The only way to get out of the basket view is to return to the homepage and start all over again by clicking on the Kitodo.Presentation logo.

As the demo installation is intended to show all features of Kitodo.Presentation, here are some suggestions for features still missing:

• show thumbnails in list view
• add fulltext search options "in this collection" and "in this document"
• add IIIF-encoded examples
• add newspapers with calendar view
• add audio examples (although I currently don't know of any institution which could provide some)
• add more diverse collections from more than just one institution
• add RSS feeds for collections
• add an extended search form with custom fields

The demo installation (at https://presentation-demo.kitodo.org/) differ from the kitodo/kitodo-demo.

In the demo installation:

<div id="c6" class="csc-default"><div class="tx-dlf-toc">
    <div class="detail-view-itemcontents">
        <div class="dropdown-menu">
            <input type="checkbox" id="checkbox-menu1">
            <label for="checkbox-menu1">Inhaltsverzeichnis</label>
            <ul>
                <li class="tx-dlf-toc-act tx-dlf-toc-ifsub">
                    ...
                </li>
            </ul>
        </div>
    </div>
</div>

In kitodo/kitodo-demo:

<a id="cXXX"></a>
<div class="tx-dlf-TableOfContents">
    <ul>
        <li class="tx-dlf-toc-act tx-dlf-toc-ifsub">
        ...
        </li>
    </ul>
</div>

Probably the template Resources/Private/Template/DetailTemplate.html is different?

• In list view, there is a rather ugly linebreak between the sorting options:
  
• In page view, there are some overflow issues with preview images of unusual ratio and with extensive table of contents:
  
• Also the hierarchy of the table of contents isn't shown.

Example: https://presentation-demo.kitodo.org/index.php?id=4&tx_dlf%5Bid%5D=857&tx_dlf%5Bpage%5D=1&cHash=2f872536b02ee5c143da93a2c9eaa22a