Comments (1)
For clarification:
- The builder's
builder.addDataEntity(DataEntity)
does add it correctly. - The crate's
crate.addDataEntity
does add it correctly withcrate.addDataEntity(DataEntity, true)
. It does not add it correctly, if the second parameter isfalse
or without it (crate.addDataEntity(DataEntity)
).
At first glance, it seems to be used with the boolean being false only once in the whole code, at the RoCrateReader, for each DataEntity. Currently, I do not understand why, but I assume that it is because in this case, it is already inside. I think we should:
- change the default from "not being added" to "being added" at least.
- But ideally, we should figure out if we can remove this "feature" completely in the end. For example, if this is about not adding something twice, we may use a set in the background (this is already the case!) and simply add it anyway. It should not change anything, then.
from ro-crate-java.
Related Issues (20)
- Encoded file paths do not work HOT 1
- Reserved keywords cause warnings
- Publish the library on a maven/gradle compatible repository. HOT 2
- Missing points in documentation
- Re-evaluate group and package names. HOT 6
- Default constructor creates invalid crate HOT 7
- Adding urls/pairs to the context without RoCrateBuilder HOT 6
- Removing urls/key-value pairs from the context is not supported HOT 4
- Removing properties from entities is too complicated HOT 1
- Check the valid use of lists in our data structures HOT 3
- Adding an entity with the same @id as RootDataEntity/JsonDescriptor should not be allowed
- ZipReader unpacks in ./temp
- Support new ROR schema (draft available)
- Multiple conformsTo values HOT 7
- Transmitting an RoCrate instance over a network HOT 5
- Guidance implementation for creating Profile Crates and using them for validation
- Missing support for provenance elements HOT 1
- Improve documentation on mandatory build dependecy 'ro-crate-html-js'
- Officially support Java 21 LTS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ro-crate-java.