Coder Social home page Coder Social logo

Comments (1)

Pfeil avatar Pfeil commented on August 18, 2024

For clarification:

  • The builder's builder.addDataEntity(DataEntity) does add it correctly.
  • The crate's crate.addDataEntity does add it correctly with crate.addDataEntity(DataEntity, true). It does not add it correctly, if the second parameter is false or without it (crate.addDataEntity(DataEntity)).

At first glance, it seems to be used with the boolean being false only once in the whole code, at the RoCrateReader, for each DataEntity. Currently, I do not understand why, but I assume that it is because in this case, it is already inside. I think we should:

  • change the default from "not being added" to "being added" at least.
  • But ideally, we should figure out if we can remove this "feature" completely in the end. For example, if this is about not adding something twice, we may use a set in the background (this is already the case!) and simply add it anyway. It should not change anything, then.

from ro-crate-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.