kishanbagaria / oclb Goto Github PK

Hi Kishan -

I've been using your wonderful One-Click Llama for some time now and now it doesn't seem to work at all with Tampermonkey on the PC I have that's running Windows 7 64-bit, but the latest Firefox. Is there something I can try to see what's going on?

Sincerely,
Peter

It works great on pre-webext (aka pre 4.0) version of GM on ESR but on versions where you can't use it and need to use the post 4.0 version (aka from 57+) then it doesn't work due to changes in the API.

Using TamperMonkey is not an option as it doesn't behave correctly and has too many quirks and even to make it run on that, you can add var in front of gmSet and gmGet to make it work, but that's not the issue really, just that TM is very finicky and with the developer shutting down the forum, its practically unsupportable.

The changes to the API for GM would mean that the two @grant entries for GM_setValue and GM_getValue need to be changed to the GM global object, aka GM.setValue and GM.getValue but that's unfortunately the only easy part of it. While the setValue is relatively without fuss, the getValue is much more involved that requires the use of async functions and await to properly return the value and avoid timing issues.

While not alot needs to be changed, it does need some reworking as with the spread of webext and the deprecation of browsers that can handle original GM, you need to bring this script inline with the newer methods to ensure compatibility. Maintaining backward compatibility if you want it, shouldm't be hard but again, needs some reworking. To avoid nagging in general, convert gmSet and gmGet to variables by adding the var it makes it more stable all around.

I have made tweaks to my own copy and have somewhat gotten it work right but still getting alot of glowing red llama errors/timeouts so hopefully you can do a less hacky version that works better. Let me know if I can help, but this would be a good start for you here: API Changes and GM.getValue and GM.setValue - hit me up if you need me to help or test anything.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Since the profile urls have been changed, OCLB displays these buttons on the overhead buttons of the @Badges account.

Very low priority, but something I thought was worth mentioning.

Hi Kishan!

Since DA have updated their website lately again, now OCLB displays only "ghost llamas", so many deviants can't send llamas badges anymore with it. A temporary fix does not help it either; affects most, if not all browsers. – The community would be really happy if you kindly provide an official update of OCLB!

Regards

19/09/23

DeviantART have changed something internally in the past 12h, now OCLB is broken.

I don't have the knowledge to fix the issue (I don't know how to reverse-engineer the NAPI (If that even is the issue!)), so hoping someone more experienced will look into this.