kirstytheproud / calculator-challenge Goto Github PK

Code

• Your JS is really neat and well psuedo coded, it’s easy for me to look at your code and understand exactly how and why you’re taking the approach you are which is awesome!
• All your operator functions are doing exactly the same thing, you should have used one function here for all of them. Then instead of referencing each individual operator from the DOM as an id, used a querySelectorAll and a class to get a node list of all the operators.

const handleOperatorClick = (e) => {
    num1 = parseFloat(calcOutput.value);
    //Display value could just be an empty string - array isn't needed
    displayValue = "";
    //declare a global variable for operator and reassign this when function is invoked
    operator = e.target.value
    calcOutput.value = operator;
  };

• As above, the display value doesn’t need to be an array - especially if you’re joining it to be a string at the end of the onNumberButtonClick? When the user clicks on a button you’re going to get a string of the number. Remember arrays are for lists of things so is not really needed. you could have just done this so that the string concatenates, which is much simpler.

const onNumberButtonClick = (e) => {
  calcNumber = e.target.innerText;
  displayValue += calcNumber;
  calcOutput.value = displayValue;
};

Site

• Lovely clean styling as usual Kirsty, page looks great!
• Would be nice to see it would work with chaining numbers e.g 5 + 1 + 7