NullPointerException in CheckBoxMenuItemIcon.getIconWidth() about substance

[kirill-grouchnikov]

I'm not seeing the crash with the latest 8.1.00dev build on my Mac. It might take me some time to test on a Windows box since that's not my dev environment.

[kirill-grouchnikov]

No crash running 8.0.02 as well on Mac with Java 1.8.0_112.

[codemasterover9000]

On Windows using Java 1.8.0_131 also doesn't crash. I found this commit in the OpenJDK repo which is referenced in the bugfixes of 1.8.0_152 which might be related:
http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/908d5fa49906

It looks like a change listener in BasicMenuItemUI is now updating the checkIcon when setHorizontalTextPosition is called.

[kirill-grouchnikov]

Confirming crash in Java 1.8.0_161 on my Mac. Will be addressed shortly in 8.1.00dev branch.

[kirill-grouchnikov]

That is actually a pretty bad change of behavior.

The UI delegate gets the chance to install its own visual decorations in the regular installDefaults() method. But then, the basic UI delegate incorrectly replaces the checkIcon set earlier with the version taken from the UIManager global table - a version that is not connected to the specific menuItem (which, in Substance's case, is needed for proper animations and size-aware painting).

There is the option to "install" a check icon factory on the UIManager, but the matching MenuItemCheckIconFactory class is in sun.swing package, only exposed to the Vista look and feel. What a mess this is.

I'll need to find the way to essentially "roll back" the check icon override.