kireerik / refo Goto Github PK

puppeteer-html2pdf should optionally handle pdfPath as a function in order to support this feature.

The current implementation is correct assuming that Gaze issue 253 (shama/gaze#253) is valid.

Copying will be needed if the above mentioned issue is not valid or if it isn't resolved.

The mentioned issue is considered invalid if it isn't the expected behavior.

Related code where copying can be implemented:

Manage file (module) changes using the hot-module-replacement library.

The Handlebars handler is no longer required once this is implemented.

Alternative way to handle front end JavaScript:

Main handler:

if (typeof html == 'string') {
	html = await handleHTML(filePath, html)

	;(filePath.substring(0, filePath.lastIndexOf('.')) + '.html')
		.saveToStaticDirectory(html)
} else
	filePath.saveToStaticDirectory(html())

Front end JavaScript:

const handleJs = require('frontend-javascript-handler')

module.exports = () => handleJs('../frontEndJavaScriptFileToHandle')

Front end JavaScript handler module:

const path = require('path')

, bundle = require('bundle-js')
, minifyJS = require('uglify-js').minify

module.exports = file => {
	const filePath = path.resolve(file)

	;(() => require(filePath))()

	let js = bundle({entry: filePath, disablebeautify: true})

	for (let i = 1; i <= 2; i++)
		js = minifyJS(js).code

	return js
}

This is not recommended because the filePath needs to be requred as a module even when it is not a module in order to have hot module replacement:

	;(() => require(filePath))()

Requiring it as a string resolves this, but this is currently not supported by hot-module-replacement:

• sidorares/hot-module-replacement#6 (comment)

• UglifyJS double processing issue (related issue: #11)

check with support:

• SolidJS await,

• output non index page html, but if there is already a folder put it inside

• withastro/astro#5465

• firebase tools behaves differently locally
   

• emotion-js/emotion#3061
   

• check with Emotion: same class for same styles issue
   

• service worker output contains unnecessary new line
   

• check with mini-css-class-name: is it possible to improve the algorithm, and modify the order so it is the same similar to the other characters
   
   

• emotion-js/emotion#3044
   

• emotion-js/emotion#2172

 
resolved with workaround (until there is a better option):

• Thom1729/Sublime-JS-Custom#140 (comment)

• firebase/firebase-tools#5999

 
implementation in consideration:

• tatethurston/astrojs-service-worker#13

, serviceWorker({
	//enableInDevelopment: true
	, workbox: {
		swDest: outDir + '/' + 'main' + '/' + 'cache' + '/' + 'index.js'
	}
})

Default usage:

asset directory within siteDirectory:

This could be a feature as well, but it can be also confusing. So it is probably recommended to separate the 2 use cases and have a different assetDirectory variable for front end JavaScript handling.

The Examples page recommends the following configuration for JS Custom:

{
  "configurations": {
    "Default": {
      "custom_template_tags": {
        "html": "scope:text.html.basic"
        , "": "scope:text.html.basic"
      }
    }
  }
}

In current versions of JS Custom, custom template options have been expanded. The custom_template_tags option has been deprecated in favor of a custom_templates option with various sub-options:

{
  "configurations": {
    "Default": {
      "custom_templates": {
        "default": "scope:text.html.basic",
        "tags": {
          "html": "scope:text.html.basic"
        }
      }
    }
  }
}

The old suggested configuration using custom_template_tags should still work, but as I recall, using "" as a custom tag was buggy, which is why the new default sub-option exists.