kin021360 / sep_project_group18

CS3343 Software Engineering Practice Project - Group18

Java testing program

https://drive.google.com/drive/folders/0B2znpjlXrr9jV3VGT0RqYUZTYlE

Git Practice Guide

• To do a development, should create a feature branch from develop. E.g. feature/abc
• The develop and master branch are protected. You could not commit/push into them directly.
• When you want to merge you feature branch into develop, you should create a pull request on GitHub and assign a reviewer to approve merging.
• Your should pull(merge) develop into your feature branch that make your feature branch up-to-date.
• Do not pull(merge) master into your feature branch because it is older than develop branch. Imagine that master branch is a production version (It should only contain the statble code).
• You could google git flow development practice.

Important

Choose Ancestor Order in SourceTree to show the correct order of history

Tools

SourceTree - the gui git management program

https://www.sourcetreeapp.com
You may need to create an Atlassian account while installing SourceTree

Setup (After installation)

Clone the repository

Create your feature branch

2. Enter your feature branch name and select from a specified commit

3. Choose develop (Mean create your feature branch which is copied from develop)

Import the project into eclipse

1. Choose the root folder "SEP_Project_Group18" as the Workspace

2. Click "File">"Import..."

3. Choose "General">"Existing Projects into Workspace

4. Choose the folder "cs3343.group18.usermanagementsystem"

5. Done

Please keep your feature branch up-to-date with develop

1. Commit all changes on your feature branch and Push
2. Switch to develop, then click Pull
3. Switch back to your feature branch
4. Click Merge, choose the history which is on origin/develop origin/HEAD develop
5. If you see the file conflict, you can try to fix it
6. If you cannot solve conflict, you can give up this merging by following command

(Click Terminal and enter):
    git merge --abort

Pull request (Merge your finished feature branch into develop)

1. After finishing your feature branch, your want to merge into develop. Goto github you will see this and click "Compare & pull request"

2. Add your command for pull request if necessary and choose the reviewers to help you approve your changes

3. In the pull request, you can see all the files changes and "Review changes" for reviewers

WinMerge (Code different compare and view)

http://winmerge.org

2. Setup WinMerge in SourceTree

Visual Studio Code (More powerfull than notepad++)

https://code.visualstudio.com

sep_project_group18's Issues

[Bug] User.requestAnnualLeave allows applying the future year annual leave

Prerequisites & Information

• Area Path: usermanagementsystem.datastructure.UserController
• Test Case Class: N/A
• Release Version: V2.0
• Severity: Critical
• Priority: High
• Reported On: 4 Dec 2017
• Reason: Defect
• Status: VerifiedFix
• Environment: jdk1.8.0_152, JUnit4, Intellij 2017.2.5

Description:

The User.requestAnnualLeave is used to handle the annual leave process. The system should only accept processing the current year annual year only but the system allows user to apply future year annaul leave. For example, this year is 2017, user should not able to apply 2018 or 2019 etc. annual leave.

Steps To Reproduce:

1. Run the system
2. Login the system
3. Select "4) --- Request annual leave."
4. Input the date " 3 12-12-2018"
5. Result will show "Annual leave(s) requested!"

Expected result:

Prompt by the system : The year should be current year only!!

Actual Result:

Annual leave(s) requested!

[Bug] User.build will always build successfully even missing some info

Prerequisites & Information

• Area Path: usermanagementsystem.datastructure.User
• Test Case Class: usermanagementsystem.test\TestUser
• Release Version: V1.0
• Severity: Warrning
• Priority: Normal
• Reported On: 4 Dec 2017
• Reason: Defect
• Status: Unconfirmed
• Environment: jdk1.8.0_152, JUnit4, Intellij 2017.2.5

Description:

The User.build function is used to create a user object. However, it will always be successfully built even there are missing information, like password, email and department information Etc. This may produce impact when a defected user object is created, it may occur system corruption.

Steps To Reproduce:

1. Run the test case - TestUser
2. Run the testUserBuild() Method
3. The getDepartmentOf() is successfully called and return null
4. Proved that a user object is created with missing information

Expected result: null
Actual Result: null

There are no error message show up.

[Bug] Supervisor.build() staffID will become 0

Prerequisites & Information

• Area Path: usermanagementsystem.datastructure.Supervisor
• Test Case Class: usermanagementsystem.test\TestSupervisor
• Release Version: V1.0
• Severity: HIGH
• Priority: HIGH
• Reported On: 4 Dec 2017
• Reason: Defect
• Status: Waiting for fix
• Environment: jdk1.8.0_152, JUnit4, Intellij 2017.2.5

Description:

The staff ID of supervisor object will return 0 only if the supervisor is native build by Supervisor.build().
The staff ID should automatically generate by the system after a new supervisor object is built. However, the actual test result shows every supervisor staff ID that created by Supervisor.build() are return 0 only ;

Steps To Reproduce:

1. Run the test case - TestSupervisor
2. Run the testSupervisorGetStaffID() Method
3. The result will show passed with expected result 0;
4. Re do the above procedure will get the same result

Expected result: 0
Actual Result: 0

There are no error message show up.

[Bug] User.assignSupervisor will return false

Prerequisites & Information

• Area Path: usermanagementsystem.datastructure.User
• Test Case Class: usermanagementsystem.test\TestUser
• Release Version: V1.0
• Severity: HIGH
• Priority: HIGH
• Reported On: 28 Nov 2017
• Reason: Defect
• Status: Waiting for fix
• Environment: jdk1.8.0_152, JUnit4, Intellij 2017.2.5

Description:

The actual result is different with the expected result. The expected result should be the correct one. After the test case run, the result should be false but the actual result is true.

Steps To Reproduce:

1. Run the test case - TestUser
2. Run the testUserAssignSupervisor_2 Method
3. The result will be shown in console
4. The error message will be displayed.

Expected result: False
Actual Result: True

exclude patterns:
java.lang.AssertionError:
Expected :false
Actual :true