kickasscommerce / kickasscommerce

A small proof of concept for building and eCommerce system based on an underlying API system.

KickAss Commerce

A small proof of concept for building an eCommerce system based on an underlying API system.

Currently built on Moltin but PRs for other systems are welcome

"So is this a new eCommerce system?"

NO! we want to give you a way to work with your favourite (API enabled) eCommerce system without the constraints it might impose on the technologies you can use or the way you implement the frontend If you're curious about the 'why' behind this project please read our blogpost about it

Requirements

• PHP ^7.0

Authors

For more information about the KickAss team and to apply for a position please us our team repository.

• Sander Mangel http://www.twitter.com/sandermangel
• David Manners http://www.twitter.com/mannersd
• Adam Paterson http://www.twitter.com/adam_paterson
• Tobias Hartmann https://www.twitter.com/ToH_82

Installation

$ composer create-project kickasscommerce/kickasscommerce=dev-develop .

More information

• check the Philosophy document
• check our alpha roadmap or create a ticket / PR to help us move this project

Examples

Anything in the app directory is example code. The app directory should be used for your project code.

Testing

$ composer test

Contributing

Please see CONTRIBUTING and CONDUCT for details.

Credits

• KickAssCommerce Team
• All Contributors

License

The MIT License (MIT). Please see License File for more information.

kickasscommerce's Issues

Add fancy interceptors

Implement something like https://github.com/goaop/framework to have fancy interceptors that allow for project specific business logic

Session data - how do the cool kids/frameworks handle that?

How do we handle session data? Stuff like user cart id's or a users active profile.
Are there standards for that?
How can we make it easy to use different drivers for storage?
Maybe even use the cache library for this? (Or is that too far out)

So many questions.

--- update ---
while browsing the world wide web I found some stuff floating about

• https://github.com/auraphp/Aura.Session
• https://symfony.com/doc/current/components/http_foundation/sessions.html
• https://github.com/stefangabos/Zebra_Session

Composer.lock should be not in the repo, the project should require PHP 7

The Composer.lock should be not in the repo, the code is not working with PHP 5, so it should require PHP 7.

Is SlimPHP the best solution for routing

We picked SlimPHP because of the ease of implementation but there is a lot more out there. I guess it depends on the direction we want to go.

Do we wanna be API based, only work with REST? Do we offer HTML rendered pages? Should we allow for our router to also function as a proxy to other services?

would Klein or Flight or even something outside of PHP be a solution?

A bit of admin

Could somebody create the following and provide write access (even if it's temp)? There is no point me setting one up to migrate it to an organisation account.

1. Packagist
2. DockerHub organisation
3. Travis-ci

Standardise APIs

There are some great ways out there to standardize API definition.
You know, to make it consistent and stuff. Nice read about it here: https://nordicapis.com/standard-api-definitions-demystified/

we should do this. some way

Lots of * in the composer.json

I know I know we are super good and writing code that will not break with BC issues but maybe we should convert the * in the composer.json to "real" values.

We suck at FE

We suck at FE and need help badly!

Is AOP a bad thing?

So this one is a question. I don't know enough about AOP from a practical sense but is it a bad thing?

Does it mean we don't know how to build a "nice" system and so have to add in a hack to let people work with it? Or does it mean we are super cool and flexible?

Move Moltin bridge to it's own repo

src/Bridge/Moltin should be moved to it's own repo

move to Moltin V2 API

Moltin Indicated they're hard at work at a version 2 of their API.
It's semi public and will be launched long before we go beta (since we don't have a date even)

So I'm voting to move the Moltin Bridge to that version
https://github.com/moltin/php-sdk/

Invalid cache key

I tried to retrieve a product with a slug value of 12cup-coffemaker, that's from Moltin's documentation example.

Then I tried a request to http://myhost/shop/product/12cup-coffemaker

Ive got an invalid cache key exception in \Cache\Adapter\Filesystem\FilesystemCachePool::getFilePath:152.

It was due to the fact that the - character is not admitted in cache keys.

It could be useful to hash the cache key; I think a base 64 encoding would be good enough.

Thank you!

Make maps Immutable

remove setters from maps. Is that even possible with the Symfony serializer?

The repo knows to much

While I was thinking about the Ninja/Dragon question my mind put our repository class into my head. I think we made a mistake I think the repo should be generic but at the moment it is moltin specific. Overall it knows too much.

Maybe when I am at home on my own I can put together a PR with the correct separation of concerns before anyone notices how bad we code!

Remove hardcoded dependencies to Moltin in router

The Product router still has some Moltin dependencies that should be removed

Add in some easy to use DI

Since we will expand this and also aim to let others extend it for their use we should have some nice di that they can use.

Make the cache interceptor wrap bridge class methods instead of repositories

At the moment the cache interceptor wraps the repository load methods. It would be cleaner to have it wrap the bridge class loading method in https://github.com/KickAssCommerce/KickAssCommerce/blob/develop/src/Product/Cache/Product.php#L29

We suck at designing logos

We suck at designing logos and need help badly!

Add build processes and code checks to the repo

All the cool kids have travis reports and code check badges in their readme. We are cool kids too so we should do this!

Are we a lib or a framework?

What the hell are we? I think this is super important as we move and grow. Do we build a KickAssCommerceLib that is a lib and then a KickAssCommerceFramework that is an example implementation of our own lib?

My definitions would be.

1. Framework tells you what tools to use and lets you use them,
2. Lib helps you do things in the tools you love best,