ki-labs / gps-permission-checks-livedata Goto Github PK

Sample project to demonstrate how GPS and Runtime Location Permission checks can be done on UI and Background Service using LiveData

Home Page: https://medium.com/ki-labs-engineering/monitoring-gps-and-location-permission-checks-using-livedata-part-1-278907344b77

License: MIT License

Kotlin 100.00%

android livedata location-services service

gps-permission-checks-livedata's People

Contributors

Stargazers

Watchers

Forkers

matheusbristot wahibhaq androidkotlinid lazercorn lumleon harloom qusibue morristech saepul8 muchori ibrahim-mrq lool8x

gps-permission-checks-livedata's Issues

Add viewpager dialog for the permission check as onboarding (low-prio)

Text can have selextavkeItemBackground for repo

Use only one channel so that only 1 is visible at a time or investigate

See if you can create extension function for both livedata

like this https://gist.github.com/80998062/162fa5591387ed9e171fdb2f7659acf5#file-sharedpreferencelivedata-kt

Introduce usecase and use it in both viewmodel and service to access pair livedata

Remove reobserve if unnecessary

Make GPS livedata as singleton via dagger

https://developer.android.com/topic/libraries/architecture/livedata

Hiding Notification and killing service when GPS is disabled

Make decision on basis of pairObserver at one place

Right after handleGps and handlePermission

Because can't use when() on pair response

Ensure 2 separate notifications are created for both gps and permission while in service mode

copy code from main project PR

Introduce LiveData also for Location (low-prio)

https://medium.com/google-developers/lifecycle-aware-data-loading-with-android-architecture-components-f95484159de4

Write test for the livedata

shown as here https://dev.to/autonomousapps/a-custom-livedata-that-has-onactive-and-oninactive-listeners----tested-4gbl

Asking for Gps first, only Gps as livedata

Introduce everything with Dagger2

separate permissions 3rd party lib and keep livedata for only service. Keep mainactivity observe simple on just GPS for now.
show both dialogs on app foreground. Keep the link click for now.

TBD PermissionStatusListener to be separated to that can be injected directly...test if it will even work
- Try keeping Permission lib for just UI so makes sense to keep livedata only for service
MainViewModel shouldn't inject Context
Also decide for once how UI should react

Incorporate new UI created by Droidninja

XML is in slack chat
Remove linearlayout later

Try Transform LiveData to return both PermissionState and GpsState

https://developer.android.com/topic/libraries/architecture/livedata

https://gist.github.com/JoseAlcerreca/4b17994cf7f5d64a61f27a2a9bdfb1fd#file-myviewmodel-java

Find better way to listen to Service state

Referring to tracking and service flags

Request Permissions and React to it

https://github.com/Fondesa/KPermissions

I am already using this https://developer.android.com/training/location/change-location-settings or this https://developers.google.com/android/reference/com/google/android/gms/location/SettingsClient which also includes using Actvity.onActivityResult to show dialog

Check for 6.0 version before calling permission

call gps instead

make the PermissionStatusListener more generic

pass array of permissions
return type of permission along with the state

Use pair observer in service as well and see if there is a need to observe forever

Gps should be updated when user goes to Settings screen and come back

Improve common mistakes with ViewModel

https://twitter.com/passsy/status/1061670191225061377?s=19

convert layout to ConstaintLayout

Does permission listener LiveData actually work?

I consider myself a beginner regarding Kotlin, so hopefully it is just me that is doing something wrong, but I have been struggling for several days to try to get this LiveData to actually work, but without success.

In the end, I built this app and just added some extra logging in the listener class to see when it actually reacts to permission changes:

class PermissionStatusListener(private val context: Context,
                               private val permissionToListen: String) : LiveData<PermissionStatus>() {

    private val TAG = "* Permission listener "
    override fun onActive() = handlePermissionCheck()

    private fun handlePermissionCheck() {
        val isPermissionGranted = ActivityCompat.checkSelfPermission(context,
                permissionToListen) == PackageManager.PERMISSION_GRANTED

        Log.d(TAG, " permission status ${isPermissionGranted}")
        if (isPermissionGranted)
            postValue(PermissionStatus.Granted())
        else
            postValue(PermissionStatus.Denied())
    }
}

sealed class PermissionStatus {
    data class Granted(
            val message: Int = R.string.permission_status_granted
    ) : PermissionStatus()
    data class Denied(
            val message: Int = R.string.permission_status_denied
    ) : PermissionStatus()
    data class Blocked(
            val message: Int = R.string.permission_status_blocked
    ) : PermissionStatus()
}

When the app starts, it shows the correct status of the permission:

2019-12-21 21:55:04.668 11799-11799/com.wahibhaq.locationservicelivedata D/* Permission listener:  permission status false

But when the permission is granted, there is no update of the LiveData, only the normal permission handling callbacks:

2019-12-21 22:20:47.899 11799-11799/com.wahibhaq.locationservicelivedata D/Permissions: No rationale.
2019-12-21 22:20:47.939 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: setView = DecorView@b80bcc5[PermissionsActivity] TM=true MM=false
2019-12-21 22:20:47.956 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: dispatchAttachedToWindow
2019-12-21 22:20:47.969 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: Relayout returned: old=[0,63][1080,2094] new=[540,1078][540,1078] result=0x7 surface={valid=true 532950945792} changed=true
2019-12-21 22:20:47.976 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: MSG_RESIZED: frame=Rect(540, 1078 - 540, 1078) ci=Rect(0, 0 - 0, 0) vi=Rect(0, 0 - 0, 0) or=1
2019-12-21 22:20:51.313 11799-11799/com.wahibhaq.locationservicelivedata D/Permissions: Just allowed.
2019-12-21 22:20:51.363 11799-11799/com.wahibhaq.locationservicelivedata I/MainActivity$permissionHandler: Activity: 2131427403
2019-12-21 22:20:51.381 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: MSG_WINDOW_FOCUS_CHANGED 0 1
2019-12-21 22:20:51.381 11799-11799/com.wahibhaq.locationservicelivedata D/InputMethodManager: prepareNavigationBarInfo() DecorView@b80bcc5[PermissionsActivity]
2019-12-21 22:20:51.413 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: MSG_WINDOW_FOCUS_CHANGED 0 0
2019-12-21 22:20:51.428 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: setWindowStopped(true) old=false
2019-12-21 22:20:51.433 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: dispatchDetachedFromWindow
2019-12-21 22:20:51.434 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: Surface release. android.view.ViewRootImpl.doDie:7979 android.view.ViewRootImpl.die:7947 android.view.WindowManagerGlobal.removeViewLocked:497 android.view.WindowManagerGlobal.removeView:435 android.view.WindowManagerImpl.removeViewImmediate:124 android.app.ActivityThread.handleDestroyActivity:4753 android.app.servertransaction.DestroyActivityItem.execute:39 android.app.servertransaction.TransactionExecutor.executeLifecycleState:145 
2019-12-21 22:20:51.644 11799-11799/com.wahibhaq.locationservicelivedata D/ViewRootImpl@ac9ab27[PermissionsActivity]: Surface release. android.view.ViewRootImpl$ViewRootHandler.handleMessage:4825 android.os.Handler.dispatchMessage:106

To me it seems that the LiveData is only updated when the observing activity is resumed, and not directly when the permission is granted.

Am I missing something obvious, or does the Android framework not allow this listener to see the changed permission and update the LiveData immediately?

Update

Hello!

The application does not work pointing to the api 29 and changing the libraries to androidx. Could you update the code please?

Greetings,
Patrick

Use native way of checking runtime permission instead of using 3rd party lib

show dialog by yourself on UI
show notification for service to avoid showing dialog and need of an activity

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.